Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309220

Re: [PATCH v5 1/2] PCI support added to ARC

Show all headers | View raw

On Thursday 14 January 2016 05:29 PM, Arnd Bergmann wrote:
> On Thursday 14 January 2016 10:51:32 Vineet Gupta wrote:
>>>>
>>>> A somewhat nicer method would be to have callback pointers in struct
>>>> pci_host_bridge, and call those when they are non-NULL so we can
>>>> remove the global pcibios_* functions from the API. That would also
>>>> bring us a big step closer to having PCI support itself as a loadable
>>>> module, and it would better reflect that those functions are really
>>>> host bridge specific rather than architecture specific. When you use
>>>> the same host bridge on multiple architectures, you typically have
>>>> the same requirements for hacks in there, but each architectures may
>>>> need to support multiple host bridges with different requirements.
>>> Since we will be constantly improving the driver and the core itself, I suggest
>>> that this functions be made __weak and in an update we can turn it struct
>>> pointers just like Arnd suggested. Is this good for you?
>>
>> There is no point in making it weak, w/o a fallback version in generic code. For
>> this series, I suggest you just remove the straggler EXPORT_SYMBOL and respin.
>>
> 
> To clarify: I don't particularly like __weak functions anywhere, but they
> are already common in drivers/pci, so we can add a couple more to reach
> the goal of removing all architecture specific code.

But I see quite a bit of "weak design pattern" in kernel is common when an API
needs to be implemented across arches and it same for most of them. I agree that
this is not as ideal from code flow analysis but saves a lot of duplication.


> However, there should never be a reason to add a __weak function in
> arch code that gets overridden by common code, that would be very confusing
> and not helpful.

Agree. That was never my suggestion anyways. I'd asked __weak version be defined
in common code so we could reuse it and elide the ARC version and at the same time
not breaking others, and in longer run removing the dups elsewhere.

Thx,
-Vineet

> 
> 	Arnd
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/2] adding PCI support to AXS10x Joao Pinto <Joao.Pinto@synopsys.com> - 2016-01-12 16:50 +0100
  [PATCH v5 1/2] PCI support added to ARC Joao Pinto <Joao.Pinto@synopsys.com> - 2016-01-12 16:50 +0100
    Re: [PATCH v5 1/2] PCI support added to ARC Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-14 06:30 +0100
      Re: [PATCH v5 1/2] PCI support added to ARC Arnd Bergmann <arnd@arndb.de> - 2016-01-14 11:30 +0100
        Re: [PATCH v5 1/2] PCI support added to ARC Joao Pinto <Joao.Pinto@synopsys.com> - 2016-01-14 11:50 +0100
          Re: [PATCH v5 1/2] PCI support added to ARC Joao Pinto <Joao.Pinto@synopsys.com> - 2016-01-14 12:00 +0100
          Re: [PATCH v5 1/2] PCI support added to ARC Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-14 12:00 +0100
            Re: [PATCH v5 1/2] PCI support added to ARC Arnd Bergmann <arnd@arndb.de> - 2016-01-14 13:10 +0100
              Re: [PATCH v5 1/2] PCI support added to ARC Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-14 13:20 +0100
    Re: [PATCH v6 1/2] PCI support added to ARC Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-14 12:20 +0100

csiph-web