Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1309208
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Sebastian Reichel <sre@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS |
| Date | Thu, 14 Jan 2016 13:10:01 +0100 |
| Message-ID | <qQOSZ-6Lb-1@gated-at.bofh.it> (permalink) |
| References | <qQMev-4Y2-29@gated-at.bofh.it> |
| X-Original-To | Kishon Vijay Abraham I <kishon@ti.com> |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 78 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Tony Lindgren <tony@atomide.com>, Ulf Hansson <ulf.hansson@linaro.org>, pali.rohar@gmail.com, pavel@ucw.cz, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, NeilBrown <neilb@suse.de>, linux-mmc@vger.kernel.org, nsekhar@ti.com |
| X-Original-Date | Thu, 14 Jan 2016 13:07:06 +0100 |
| X-Original-Message-ID | <20160114120706.GA12774@earth> |
| X-Original-References | <1452762920-2588-1-git-send-email-kishon@ti.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1309208 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
Hi,
On Thu, Jan 14, 2016 at 02:45:20PM +0530, Kishon Vijay Abraham I wrote:
> Since v4.3+, CONFIG_REGULATOR_PBIAS should be enabled (for platforms that
> have PBIAS regulator) in order for MMC1 to work.
>
> Add a more verbose print to help enable CONFIG_REGULATOR_PBIAS for users
> using a olddefconfig or a custom .config.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/mmc/host/omap_hsmmc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 7fb0753..7086bd6 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -503,8 +503,11 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host)
> host->pbias = devm_regulator_get_optional(host->dev, "pbias");
> if (IS_ERR(host->pbias)) {
> ret = PTR_ERR(host->pbias);
> - if ((ret != -ENODEV) && host->dev->of_node)
> + if ((ret != -ENODEV) && host->dev->of_node) {
> + dev_err(host->dev,
> + "SD card detect fail? enable CONFIG_REGULATOR_PBIAS\n");
> return ret;
> + }
> dev_dbg(host->dev, "unable to get pbias regulator %ld\n",
> PTR_ERR(host->pbias));
> host->pbias = NULL;
Is there a good reason against adding "depends on REGULATOR_PBIAS"
to MMC_OMAP_HS? I guess it's required for most systems and the regulator
driver is just 250 loc. I am aware, that this will disable the
hsmmc driver for 'make oldconfig', but I guess that will be noticed
in a similar way your warning is noticed.
The advantage of having the depends line is, that people configuring
their kernel have a chance to notice the regulator requirement
during configuration.
Anyways, this message improves the situation, so:
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS Kishon Vijay Abraham I <kishon@ti.com> - 2016-01-14 10:20 +0100
Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS Sebastian Reichel <sre@kernel.org> - 2016-01-14 13:10 +0100
Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS Kishon Vijay Abraham I <kishon@ti.com> - 2016-01-14 13:50 +0100
Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS Tony Lindgren <tony@atomide.com> - 2016-01-14 18:00 +0100
Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-14 18:30 +0100
Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS Sebastian Reichel <sre@kernel.org> - 2016-01-14 23:50 +0100
Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-15 10:20 +0100
csiph-web