Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS
Date	2016-01-14 18:00 +0100
Message-ID	<qQTpF-1kn-29@gated-at.bofh.it> (permalink)
References	<qQMev-4Y2-29@gated-at.bofh.it> <qQOSZ-6Lb-1@gated-at.bofh.it> <qQPvI-75K-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Kishon Vijay Abraham I <kishon@ti.com> [160114 04:39]:
> On Thursday 14 January 2016 05:37 PM, Sebastian Reichel wrote:
> > 
> > Is there a good reason against adding "depends on REGULATOR_PBIAS"
> > to MMC_OMAP_HS? I guess it's required for most systems and the regulator
> > driver is just 250 loc. I am aware, that this will disable the
> > hsmmc driver for 'make oldconfig', but I guess that will be noticed
> > in a similar way your warning is noticed.
> 
> hmm.. only MMC1 requires PBIAS so I'm not sure if it's okay to add depends on
> REGULATOR_PBIAS for the HSMMC driver as such. And as you said it'll also
> disable the hsmmc driver if oldconfig is used. But do we get a warning?

Adding depends there is a bit wrong, many designs are not using MMC1
but use eMMC on the other controllers instead. I think the runtime
warning is best we can do here to keep things modular.

Regards,

Tony

Thread

[PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS Kishon Vijay Abraham I <kishon@ti.com> - 2016-01-14 10:20 +0100
  Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable  CONFIG_REGULATOR_PBIAS Sebastian Reichel <sre@kernel.org> - 2016-01-14 13:10 +0100
    Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable  CONFIG_REGULATOR_PBIAS Kishon Vijay Abraham I <kishon@ti.com> - 2016-01-14 13:50 +0100
      Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable  CONFIG_REGULATOR_PBIAS Tony Lindgren <tony@atomide.com> - 2016-01-14 18:00 +0100
    Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable  CONFIG_REGULATOR_PBIAS Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-14 18:30 +0100
      Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable  CONFIG_REGULATOR_PBIAS Sebastian Reichel <sre@kernel.org> - 2016-01-14 23:50 +0100
        Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable  CONFIG_REGULATOR_PBIAS Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-15 10:20 +0100

csiph-web