Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks
Date	2016-01-14 06:50 +0100
Message-ID	<qQIXf-2y1-11@gated-at.bofh.it> (permalink)
References	<qPKoq-2P4-3@gated-at.bofh.it> <qPKor-2P4-29@gated-at.bofh.it> <qPLua-3uR-11@gated-at.bofh.it> <qPLuc-3uR-37@gated-at.bofh.it> <qPNcB-4IN-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 11, 2016 at 09:38:27PM +0530, Viresh Kumar wrote:
> On 11-01-16, 14:14, Måns Rullgård wrote:
> > Viresh Kumar <viresh.kumar@linaro.org> writes:
> > 
> > > On 11-01-16, 13:04, Mans Rullgard wrote:
> > >> Cyclic transfer callbacks rely on block completion interrupts which were
> > >> disabled in commit ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block
> > >> interrupts").  This re-enables block interrupts so the cyclic callbacks
> > >> can work.  Other transfer types are not affected as they set the INT_EN
> > >> bit only on the last block.
> > >> 
> > >> Fixes: ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block interrupts")
> > >> Signed-off-by: Mans Rullgard <mans@mansr.com>
> > >> ---
> > >> Changes:
> > >> - new patch
> > >> ---
> > >>  drivers/dma/dw/core.c | 21 +++++++++++++++------
> > >>  1 file changed, 15 insertions(+), 6 deletions(-)
> > >
> > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> > >
> > > BTW, Shouldn't you mark these for stable trees as well ? :)
> > 
> > Probably.  Some maintainers prefer to do that themselves, but apparently
> > you're not one of them.
> 
> Vinod is the maintainer who is going to apply the patch :)

Letting know is fine too, either commenting after the SOB line or adding CC
line.. Maintainers can add/remove :)

-- 
~Vinod

Thread

[PATCH v2 0/2] dmaengine: dw: fix cyclic transfers Mans Rullgard <mans@mansr.com> - 2016-01-11 14:10 +0100
  [PATCH v2 1/2] dmaengine: dw: fix cyclic transfer setup Mans Rullgard <mans@mansr.com> - 2016-01-11 14:10 +0100
    Re: [PATCH v2 1/2] dmaengine: dw: fix cyclic transfer setup Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-11 15:10 +0100
  [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Mans Rullgard <mans@mansr.com> - 2016-01-11 14:10 +0100
    Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-11 15:20 +0100
      Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Måns Rullgård <mans@mansr.com> - 2016-01-11 15:20 +0100
        Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-11 17:10 +0100
          Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Vinod Koul <vinod.koul@intel.com> - 2016-01-14 06:50 +0100
    Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Måns Rullgård <mans@mansr.com> - 2016-01-11 16:10 +0100
      Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-11 16:20 +0100
        Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Måns Rullgård <mans@mansr.com> - 2016-01-11 16:30 +0100
          Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-11 16:30 +0100
    Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-11 16:10 +0100
  Re: [PATCH v2 0/2] dmaengine: dw: fix cyclic transfers Vinod Koul <vinod.koul@intel.com> - 2016-01-14 06:50 +0100

csiph-web