Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1306257

Re: [PATCH v2 1/2] dmaengine: dw: fix cyclic transfer setup

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/2] dmaengine: dw: fix cyclic transfer setup
Date 2016-01-11 15:10 +0100
Message-ID <qPLku-3rc-11@gated-at.bofh.it> (permalink)
References <qPKoq-2P4-3@gated-at.bofh.it> <qPKoq-2P4-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 11-01-16, 13:04, Mans Rullgard wrote:
> Commit 61e183f83069 ("dmaengine/dw_dmac: Reconfigure interrupt and
> chan_cfg register on resume") moved some channel initialisation to
> a new function which must be called before starting a transfer.
> 
> This updates dw_dma_cyclic_start() to use dwc_dostart() like the other
> modes, thus ensuring dwc_initialize() gets called and removing some code
> duplication.
> 
> Fixes: 61e183f83069 ("dmaengine/dw_dmac: Reconfigure interrupt and chan_cfg register on resume")
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> Changes:
> - replace duplicated code by dwc_dostart() call
> ---
>  drivers/dma/dw/core.c | 23 +----------------------
>  1 file changed, 1 insertion(+), 22 deletions(-)

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/2] dmaengine: dw: fix cyclic transfers Mans Rullgard <mans@mansr.com> - 2016-01-11 14:10 +0100
  [PATCH v2 1/2] dmaengine: dw: fix cyclic transfer setup Mans Rullgard <mans@mansr.com> - 2016-01-11 14:10 +0100
    Re: [PATCH v2 1/2] dmaengine: dw: fix cyclic transfer setup Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-11 15:10 +0100
  [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Mans Rullgard <mans@mansr.com> - 2016-01-11 14:10 +0100
    Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-11 15:20 +0100
      Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Måns Rullgård <mans@mansr.com> - 2016-01-11 15:20 +0100
        Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-11 17:10 +0100
          Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Vinod Koul <vinod.koul@intel.com> - 2016-01-14 06:50 +0100
    Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Måns Rullgård <mans@mansr.com> - 2016-01-11 16:10 +0100
      Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-11 16:20 +0100
        Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Måns Rullgård <mans@mansr.com> - 2016-01-11 16:30 +0100
          Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-11 16:30 +0100
    Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-11 16:10 +0100
  Re: [PATCH v2 0/2] dmaengine: dw: fix cyclic transfers Vinod Koul <vinod.koul@intel.com> - 2016-01-14 06:50 +0100

csiph-web