Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1307123
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice |
| Date | 2016-01-12 10:00 +0100 |
| Message-ID | <qQ2Y2-6UJ-11@gated-at.bofh.it> (permalink) |
| References | <qPNcB-4IN-15@gated-at.bofh.it> <qQ2EH-6Ka-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Cyrille Pitchen <cyrille.pitchen@atmel.com> writes:
> Hi Mans,
>
> I've tried to apply your patch on a next-20160112 branch to test it but it
> failed. I've also looked at the for-next branch of the SPI sub-system git
> tree.
>
> It seems that one issue occurred within a chunk patching the atmel_spi_setup()
> function. Please see below.
>
> Le 11/01/2016 17:01, Mans Rullgard a écrit :
> [...]
>> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
>> index 08cbb3e43c76..d4a806e24060 100644
>> --- a/drivers/spi/spi-atmel.c
>> +++ b/drivers/spi/spi-atmel.c
> [...]
>> @@ -1603,6 +1611,7 @@ static int atmel_spi_setup(struct spi_device *spi)
>> }
>>
>> asd->npcs_pin = npcs_pin;
>> + asd->use_cs_gpio = use_cs_gpio;
>> spi->controller_state = asd;
>> } else {
>> atmel_spi_lock(as);
> [...]
>
> There is no 'else' statement in the source code I'm looking at.
Sorry, I'll send a new patch against the correct base. I forgot I had
something else earlier in my local branch.
--
Måns Rullgård
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Mans Rullgard <mans@mansr.com> - 2016-01-11 17:10 +0100
Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Måns Rullgård <mans@mansr.com> - 2016-01-11 17:20 +0100
Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Mark Brown <broonie@kernel.org> - 2016-01-11 17:30 +0100
Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Mark Brown <broonie@kernel.org> - 2016-01-11 17:20 +0100
Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-01-12 09:40 +0100
Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Måns Rullgård <mans@mansr.com> - 2016-01-12 10:00 +0100
Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-01-12 10:00 +0100
csiph-web