Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1306458

Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice

From Måns Rullgård <mans@mansr.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice
Date 2016-01-11 17:20 +0100
Message-ID <qPNmh-4Mf-15@gated-at.bofh.it> (permalink)
References <qPNcB-4IN-15@gated-at.bofh.it> <qPNmh-4Mf-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Mark Brown <broonie@kernel.org> writes:

> On Mon, Jan 11, 2016 at 04:01:42PM +0000, Mans Rullgard wrote:
>> The driver currently chooses between internal chip-select or gpio
>> based on the existence of the cs-gpios DT property which fails on
>> non-DT systems and also enforces the same choice for all devices.
>
> Normally you shouldn't send incremental patches against patches that
> have already been applied.

Should or shouldn't?

> However in this case I'm going to drop your original patch anyway due
> to the issue that was found so it's OK.

Sorry, I hadn't noticed it was already applied.  Too many trees to keep
track of.

-- 
Måns Rullgård

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Mans Rullgard <mans@mansr.com> - 2016-01-11 17:10 +0100
  Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Måns Rullgård <mans@mansr.com> - 2016-01-11 17:20 +0100
    Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select  choice Mark Brown <broonie@kernel.org> - 2016-01-11 17:30 +0100
  Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select  choice Mark Brown <broonie@kernel.org> - 2016-01-11 17:20 +0100
  Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select  choice Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-01-12 09:40 +0100
    Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Måns Rullgård <mans@mansr.com> - 2016-01-12 10:00 +0100
  Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select  choice Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-01-12 10:00 +0100

csiph-web