Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers
Date	2016-01-10 12:50 +0100
Message-ID	<qPmFr-3Dh-3@gated-at.bofh.it> (permalink)
References	<qNbEt-2Rt-3@gated-at.bofh.it> <qNbEt-2Rt-1@gated-at.bofh.it> <qNfRL-5IQ-1@gated-at.bofh.it> <qNkeK-8sV-11@gated-at.bofh.it> <qNlDR-14y-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 04, 2016 at 02:15:50PM -0800, Joe Perches wrote:
> On Mon, 2016-01-04 at 22:45 +0200, Michael S. Tsirkin wrote:
> > On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote:
> > > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote:
> > > > SMP-only barriers were missing in checkpatch.pl
> > > > 
> > > > Refactor code slightly to make adding more variants easier.
> > > > 
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > > ---
> > > >  scripts/checkpatch.pl | 9 ++++++++-
> > > >  1 file changed, 8 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > > index 2b3c228..0245bbe 100755
> > > > --- a/scripts/checkpatch.pl
> > > > +++ b/scripts/checkpatch.pl
> > > > @@ -5116,7 +5116,14 @@ sub process {
> > > >  			}
> > > >  		}
> > > >  # check for memory barriers without a comment.
> > > > -		if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
> > > > +
> > > > +		my @barriers = ('mb', 'rmb', 'wmb', 'read_barrier_depends');
> > > > +		my @smp_barriers = ('smp_store_release', 'smp_load_acquire', 'smp_store_mb');
> > > > +
> > > > +		@smp_barriers = (@smp_barriers, map {"smp_" . $_} @barriers);
> > > 
> > > I think using map, which so far checkpatch doesn't use,
> > > makes smp_barriers harder to understand and it'd be
> > > better to enumerate them.
> > 
> > Okay - I'll rewrite using foreach.
> > 
> 
> I think using the qr form (like 'our $Attribute' and
> a bunch of others) is the general style that should
> be used for checkpatch.

Thanks - that's what I did in the new version (included in
v3 of the arch cleanup patchset now).

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] checkpatch.pl: add missing memory barriers "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-04 12:40 +0100
  Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers Joe Perches <joe@perches.com> - 2016-01-04 17:10 +0100
    Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-04 17:20 +0100
      Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers Joe Perches <joe@perches.com> - 2016-01-04 17:20 +0100
    Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-04 21:50 +0100
      Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers Joe Perches <joe@perches.com> - 2016-01-04 23:20 +0100
        Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-10 12:50 +0100

csiph-web