[PATCH 1/3] checkpatch.pl: add missing memory barriers

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] checkpatch.pl: add missing memory barriers
Date	2016-01-04 12:40 +0100
Message-ID	<qNbEt-2Rt-1@gated-at.bofh.it> (permalink)
References	<qNbEt-2Rt-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

SMP-only barriers were missing in checkpatch.pl

Refactor code slightly to make adding more variants easier.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 scripts/checkpatch.pl | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2b3c228..0245bbe 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5116,7 +5116,14 @@ sub process {
 			}
 		}
 # check for memory barriers without a comment.
-		if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
+
+		my @barriers = ('mb', 'rmb', 'wmb', 'read_barrier_depends');
+		my @smp_barriers = ('smp_store_release', 'smp_load_acquire', 'smp_store_mb');
+
+		@smp_barriers = (@smp_barriers, map {"smp_" . $_} @barriers);
+		my $all_barriers = join('|', (@barriers, @smp_barriers));
+
+		if ($line =~ /\b($all_barriers)\(/) {
 			if (!ctx_has_comment($first_line, $linenr)) {
 				WARN("MEMORY_BARRIER",
 				     "memory barrier without comment\n" . $herecurr);
-- 
MST

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] checkpatch.pl: add missing memory barriers "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-04 12:40 +0100
  Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers Joe Perches <joe@perches.com> - 2016-01-04 17:10 +0100
    Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-04 17:20 +0100
      Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers Joe Perches <joe@perches.com> - 2016-01-04 17:20 +0100
    Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-04 21:50 +0100
      Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers Joe Perches <joe@perches.com> - 2016-01-04 23:20 +0100
        Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-10 12:50 +0100

csiph-web