Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1305382
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Pali Rohár <pali.rohar@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition |
| Date | Sat, 09 Jan 2016 23:50:03 +0100 |
| Message-ID | <qPauD-3CC-29@gated-at.bofh.it> (permalink) |
| References | <qM5KO-1Gt-13@gated-at.bofh.it> <qM649-1Nv-3@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=WCqPVEEGxnVTklALDsYyv02KKMR6llZUGyx3hn3q6/4=; b=w/Y1Q9KYjusVJYlr1gewXmUM5kGrgvGEHi6/npxEIYqAYL2KasGDGRPl5mDa0U9dl/ dfuatQQu7tFn3w1aEhYNFBs2tDh4AIfkAldUZ0rRjabkQyNeEmWk37MDiua/oXjVyXUC 6bDdvTAOP2EZZ1Ew2kZLI0z68urdXpp7HplswVQYDOdGNQyDI/9zvKgIkJavW20+f9EK B2xG4vvuaOTjBrEe86hH/BqebFWQxXYM5eLiCUeP3LY/tyDoyiw/8KtTY+u6QFo0RNXx OiYNifw19xu9HqyOeXnB0/5/9OTN0cactsCVLdwK5qRfDLPBYMpk1snRuAkooCUufSkz eXrA== |
| X-Received | by 10.194.200.106 with SMTP id jr10mr78447649wjc.100.1452379351903; Sat, 09 Jan 2016 14:42:31 -0800 (PST) |
| User-Agent | KMail/1.13.7 (Linux/3.13.0-71-generic; KDE/4.14.2; x86_64; ; ) |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; boundary="nextPart2799918.nU0oy9oeiC"; protocol="application/pgp-signature"; micalg=pgp-sha1 |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 44 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | dbaryshkov@gmail.com, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz> |
| X-Original-Date | Sat, 9 Jan 2016 23:42:30 +0100 |
| X-Original-Message-ID | <201601092342.30608@pali> |
| X-Original-References | <1451646209-11618-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <201601011226.21552@pali> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1305382 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
On Friday 01 January 2016 12:26:21 Pali Rohár wrote: > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote: > > All calls to isp1704_write() are using parameter sequence of > > isp1704_write(isp, reg, val) but the function is defined as > > isp1704_write(isp, val, reg). Fix isp1704_write function definition > > so that the driver to be functional. > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > > Reviewed-by: Pali Rohár <pali.rohar@gmail.com> > > This problem is there since inclusion of driver itself. No idea why > that driver could work... I remember that it detected correctly type > of charger. > > I will test this patch on real N900 HW in one or two weeks to check > how it behave after patching... Tested-by: Pali Rohár <pali.rohar@gmail.com> Please send this patch to all stable kernels. -- Pali Rohár pali.rohar@gmail.com
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Pali Rohár <pali.rohar@gmail.com> - 2016-01-09 23:50 +0100
csiph-web