Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1305377

Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy()

From Andy Lutomirski <luto@amacapital.net>
Newsgroups linux.kernel
Subject Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy()
Date 2016-01-09 23:40 +0100
Message-ID <qPakW-3yt-15@gated-at.bofh.it> (permalink)
References (2 earlier) <qOQPf-6LO-7@gated-at.bofh.it> <qP5Oi-od-1@gated-at.bofh.it> <qP5XX-rn-1@gated-at.bofh.it> <qP7Gq-1HI-3@gated-at.bofh.it> <qPa1B-3rw-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Jan 9, 2016 at 2:15 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Sat, Jan 9, 2016 at 11:39 AM, Tony Luck <tony.luck@gmail.com> wrote:
>> On Sat, Jan 9, 2016 at 9:57 AM, Andy Lutomirski <luto@amacapital.net> wrote:
>>> On Sat, Jan 9, 2016 at 9:48 AM, Tony Luck <tony.luck@gmail.com> wrote:
>>>> ERMS?
>>>
>>> It's the fast string extension, aka Enhanced REP MOV STOS.  On CPUs
>>> with that feature (and not disabled via MSR), plain ol' rep movs is
>>> the fastest way to copy bytes.  I think this includes all Intel CPUs
>>> from SNB onwards.
>>
>> Ah ... very fast at copying .. but currently not machine check recoverable.
>
> Hmm, I assume for the pmem driver I'll want to check at runtime if the
> cpu has machine check recovery and fall back to the faster copy if
> it's not available?

Shouldn't that logic live in the mcsafe_copy routine itself rather
than being delegated to callers?

--Andy

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@intel.com> - 2016-01-09 01:20 +0100
  Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-09 02:50 +0100
    Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@gmail.com> - 2016-01-09 18:50 +0100
      Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-09 19:00 +0100
        Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@gmail.com> - 2016-01-09 20:50 +0100
          Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Dan Williams <dan.j.williams@intel.com> - 2016-01-09 23:20 +0100
            Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-09 23:40 +0100
              Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Dan Williams <dan.j.williams@intel.com> - 2016-01-10 01:30 +0100
                Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@gmail.com> - 2016-01-10 02:50 +0100
                Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Borislav Petkov <bp@alien8.de> - 2016-01-10 12:30 +0100
                Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Ingo Molnar <mingo@kernel.org> - 2016-01-11 11:50 +0100
                Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@gmail.com> - 2016-01-14 00:30 +0100
                Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Borislav Petkov <bp@alien8.de> - 2016-01-14 05:50 +0100
    Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() "Luck, Tony" <tony.luck@intel.com> - 2016-01-12 01:30 +0100
      Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-12 01:40 +0100
      Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-12 01:40 +0100

csiph-web