Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1306851
| From | "Luck, Tony" <tony.luck@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() |
| Date | 2016-01-12 01:30 +0100 |
| Message-ID | <qPV0u-1AF-7@gated-at.bofh.it> (permalink) |
| References | <qOPq9-5WM-3@gated-at.bofh.it> <qOPq9-5WM-1@gated-at.bofh.it> <qOQPf-6LO-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jan 08, 2016 at 05:49:30PM -0800, Andy Lutomirski wrote:
> Also, what's the sfence for? You don't seem to be using any
> non-temporal operations.
So I deleted the "sfence" and now I just have a comment
at the 100: label.
37:
shl $6,%ecx
lea -48(%ecx,%edx),%edx
jmp 100f
38:
shl $6,%ecx
lea -56(%ecx,%edx),%edx
jmp 100f
39:
lea (%rdx,%rcx,8),%rdx
jmp 100f
40:
mov %ecx,%edx
100:
/* %rax set the fault number in fixup_exception() */
ret
Should I just change all the "jmp 100f" into "ret"? There
aren't any tools that will be confused that the function
has 10 returns, are there?
-Tony
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@intel.com> - 2016-01-09 01:20 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-09 02:50 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@gmail.com> - 2016-01-09 18:50 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-09 19:00 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@gmail.com> - 2016-01-09 20:50 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Dan Williams <dan.j.williams@intel.com> - 2016-01-09 23:20 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-09 23:40 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Dan Williams <dan.j.williams@intel.com> - 2016-01-10 01:30 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@gmail.com> - 2016-01-10 02:50 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Borislav Petkov <bp@alien8.de> - 2016-01-10 12:30 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Ingo Molnar <mingo@kernel.org> - 2016-01-11 11:50 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck <tony.luck@gmail.com> - 2016-01-14 00:30 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Borislav Petkov <bp@alien8.de> - 2016-01-14 05:50 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() "Luck, Tony" <tony.luck@intel.com> - 2016-01-12 01:30 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-12 01:40 +0100
Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Andy Lutomirski <luto@amacapital.net> - 2016-01-12 01:40 +0100
csiph-web