Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1305390

Re: [GIT PULL] aio: a couple of fixes for 4.4

From Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups linux.kernel
Subject Re: [GIT PULL] aio: a couple of fixes for 4.4
Date 2016-01-10 00:10 +0100
Message-ID <qPaNY-41a-29@gated-at.bofh.it> (permalink)
References <qP9RU-3o9-9@gated-at.bofh.it> <qPauD-3CC-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Jan 09, 2016 at 02:43:44PM -0800, Linus Torvalds wrote:
> On Sat, Jan 9, 2016 at 2:08 PM, Benjamin LaHaise <bcrl@kvack.org> wrote:
> >
> > Please consider pulling the following changes to fix a couple of issues
> > reported by Dmitry from git://git.kvack.org/~bcrl/aio-fixes.git .
> 
> No. This is much too late for this kind of hackery. That second patch
> in particular is both subtle and ugly, and is messing with lockdep.
> 
> No way will I take something like this the last fay before a release.
> 
> It's not even a regression, nor did you send me anything at all for
> this release. Trying to sneak something in just before 4.4 is not ok.

BTW, right now vfs.git#for-linus contains minimal compat_ioctl patches; unless
you want those in right now, I'm holding them back until Monday.  It's
two patches Jann has posted (with trivial fix in the first one folded in) +
not passing fd around where it's not needed (basically, those calls of
do_ioctl() in there are guaranteed to go into vfs_ioctl() - the paths in
do_vfs_ioctl() that care about the descriptor numbers are not reachable
with the arguments do_ioctl() is getting).

If for some reason you want those in before -final - yell and I'll send
a pull request, otherwise they'll be in one of the first pull requests
on Monday.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT PULL] aio: a couple of fixes for 4.4 Benjamin LaHaise <bcrl@kvack.org> - 2016-01-09 23:10 +0100
  Re: [GIT PULL] aio: a couple of fixes for 4.4 Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-09 23:50 +0100
    Re: [GIT PULL] aio: a couple of fixes for 4.4 Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-10 00:10 +0100
      Re: [GIT PULL] aio: a couple of fixes for 4.4 Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-10 05:40 +0100
    Re: [GIT PULL] aio: a couple of fixes for 4.4 Benjamin LaHaise <bcrl@kvack.org> - 2016-01-10 00:10 +0100
      Re: [GIT PULL] aio: a couple of fixes for 4.4 Jan Kara <jack@suse.cz> - 2016-01-11 18:00 +0100

csiph-web