Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305391

Re: [GIT PULL] aio: a couple of fixes for 4.4

Show all headers | View raw

On Sat, Jan 09, 2016 at 02:43:44PM -0800, Linus Torvalds wrote:
> On Sat, Jan 9, 2016 at 2:08 PM, Benjamin LaHaise <bcrl@kvack.org> wrote:
> >
> > Please consider pulling the following changes to fix a couple of issues
> > reported by Dmitry from git://git.kvack.org/~bcrl/aio-fixes.git .
> 
> No. This is much too late for this kind of hackery. That second patch
> in particular is both subtle and ugly, and is messing with lockdep.

I wasn't particularly fond of how Jan implemented that.  Any ideas on a 
better way to avoid lockdep complaining about this?  My initial feedback 
to Jan was exactly that this should be handled within the file_start_write() 
and file_end_write() APIs -- AIO really shouldn't need to be mucking in what 
ought to be hidden behind that API.

> No way will I take something like this the last fay before a release.
> 
> It's not even a regression, nor did you send me anything at all for
> this release. Trying to sneak something in just before 4.4 is not ok.

Okay, no worries.

		-ben

>                      Linus

-- 
"Thought is the essence of where you are now."

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] aio: a couple of fixes for 4.4 Benjamin LaHaise <bcrl@kvack.org> - 2016-01-09 23:10 +0100
  Re: [GIT PULL] aio: a couple of fixes for 4.4 Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-09 23:50 +0100
    Re: [GIT PULL] aio: a couple of fixes for 4.4 Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-10 00:10 +0100
      Re: [GIT PULL] aio: a couple of fixes for 4.4 Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-10 05:40 +0100
    Re: [GIT PULL] aio: a couple of fixes for 4.4 Benjamin LaHaise <bcrl@kvack.org> - 2016-01-10 00:10 +0100
      Re: [GIT PULL] aio: a couple of fixes for 4.4 Jan Kara <jack@suse.cz> - 2016-01-11 18:00 +0100

csiph-web