Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

From	Timur Tabi <timur@tabi.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults
Date	2016-01-11 16:50 +0100
Message-ID	<qPMTf-4l0-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <qPJsm-2ay-15@gated-at.bofh.it> <qPJC2-2eG-13@gated-at.bofh.it> <qPLku-3rc-5@gated-at.bofh.it> <qPLuc-3uR-41@gated-at.bofh.it> <qPM6S-3KB-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Mark Brown wrote:
> That's possibly problematic because the flat cache will of necessity end
> up with defaults (of 0 from the kzalloc()) for all the registers.
> You'll still have default values in the cache, though some of the
> behaviour around optimising syncs does change without them explicitly
> given.  It does deal with the allocation issue but given that the issue
> was incorrect defaults I'd be a bit concerned.

Ok, I'm confused.  Granted, all of this regcache stuff was added after I 
stopped working on this driver, so I'm out of the loop.  But it appears 
that the regcache cannot properly handle an uninitialized cache.  I 
would expect it to know to perform hard reads of any registers that are 
uninitialized.

If the regcache wants to have an initialized cache, then it should 
automatically perform reads an all non-volatile, non-precious registers 
at initialization.

Thread

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Fabio Estevam <festevam@gmail.com> - 2016-01-11 13:10 +0100
  Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Fabio Estevam <festevam@gmail.com> - 2016-01-11 13:20 +0100
    Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2016-01-11 15:00 +0100
      Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Fabio Estevam <festevam@gmail.com> - 2016-01-11 15:10 +0100
    Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Mark Brown <broonie@kernel.org> - 2016-01-11 15:10 +0100
      Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2016-01-11 15:20 +0100
        Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Mark Brown <broonie@kernel.org> - 2016-01-11 16:00 +0100
          Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Timur Tabi <timur@tabi.org> - 2016-01-11 16:50 +0100
            Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Mark Brown <broonie@kernel.org> - 2016-01-11 17:20 +0100
              Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Timur Tabi <timur@tabi.org> - 2016-01-12 02:30 +0100
                Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Mark Brown <broonie@kernel.org> - 2016-01-12 02:40 +0100
                Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Timur Tabi <timur@tabi.org> - 2016-01-12 03:00 +0100

csiph-web