Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1306255
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults |
| Date | 2016-01-11 15:10 +0100 |
| Message-ID | <qPLku-3rc-5@gated-at.bofh.it> (permalink) |
| References | <qHSVP-5qX-5@gated-at.bofh.it> <qPJsm-2ay-15@gated-at.bofh.it> <qPJC2-2eG-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Mon, Jan 11, 2016 at 10:10:56AM -0200, Fabio Estevam wrote:
> On Mon, Jan 11, 2016 at 10:04 AM, Fabio Estevam <festevam@gmail.com> wrote:
> > [ 2.526984] ------------[ cut here ]------------
> > [ 2.531632] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:2755
> > lockdep_trace_alloc+0xf4/0x124()
> This fixes the warning:
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -180,7 +180,6 @@ static const struct regmap_config fsl_ssi_regconfig = {
> .volatile_reg = fsl_ssi_volatile_reg,
> .precious_reg = fsl_ssi_precious_reg,
> .writeable_reg = fsl_ssi_writeable_reg,
> - .cache_type = REGCACHE_RBTREE,
> };
> Is this the correct fix?
I suspect not, it looks like the driver is using the cache for
suspend/resume handling. I've dropped the patch for now. Either the
driver should explicitly write to the relevant registers outside of
interrupt context to ensure the cache entry exists or it should keep the
defaults and explicitly write them to hardware at startup to ensure
sync (the former is more likely to be safe).
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Fabio Estevam <festevam@gmail.com> - 2016-01-11 13:10 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Fabio Estevam <festevam@gmail.com> - 2016-01-11 13:20 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2016-01-11 15:00 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Fabio Estevam <festevam@gmail.com> - 2016-01-11 15:10 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Mark Brown <broonie@kernel.org> - 2016-01-11 15:10 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2016-01-11 15:20 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Mark Brown <broonie@kernel.org> - 2016-01-11 16:00 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Timur Tabi <timur@tabi.org> - 2016-01-11 16:50 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Mark Brown <broonie@kernel.org> - 2016-01-11 17:20 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Timur Tabi <timur@tabi.org> - 2016-01-12 02:30 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Mark Brown <broonie@kernel.org> - 2016-01-12 02:40 +0100
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Timur Tabi <timur@tabi.org> - 2016-01-12 03:00 +0100
csiph-web