Re: [PATCH] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Stanislaw Gruszka <sgruszka@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free
Date	Mon, 11 Jan 2016 13:20:02 +0100
Message-ID	<qPJC2-2eG-29@gated-at.bofh.it> (permalink)
References	<qOhou-7Bh-1@gated-at.bofh.it>
X-Original-To	Jia-Ju Bai <baijiaju1990@163.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.26
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	10
Organization	linux.* mail to news gateway
X-Original-Cc	kvalo@codeaurora.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 11 Jan 2016 13:12:08 +0100
X-Original-Message-ID	<20160111121208.GD25015@redhat.com>
X-Original-References	<1452167498-10823-1-git-send-email-baijiaju1990@163.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1306128

Show key headers only | View raw

On Thu, Jan 07, 2016 at 07:51:38PM +0800, Jia-Ju Bai wrote:
>  err:
> -	for (i = 0; i < actual_slots; i++)
> +	for (i = 0; i < actual_slots; i++) {
>  		kfree(txq->cmd[i]);
> +		txq->cmd[i] = NULL;

I don't think we need this, otherwise patch looks good.

Stanislaw

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free Jia-Ju Bai <baijiaju1990@163.com> - 2016-01-07 13:00 +0100
  Re: [PATCH] iwl4965: Fix a null pointer dereference in  il_tx_queue_free and il_cmd_queue_free Stanislaw Gruszka <sgruszka@redhat.com> - 2016-01-11 13:20 +0100

csiph-web