Re: [PATCH] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free

From	Stanislaw Gruszka <sgruszka@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free
Date	2016-01-11 13:20 +0100
Message-ID	<qPJC2-2eG-29@gated-at.bofh.it> (permalink)
References	<qOhou-7Bh-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 07, 2016 at 07:51:38PM +0800, Jia-Ju Bai wrote:
>  err:
> -	for (i = 0; i < actual_slots; i++)
> +	for (i = 0; i < actual_slots; i++) {
>  		kfree(txq->cmd[i]);
> +		txq->cmd[i] = NULL;

I don't think we need this, otherwise patch looks good.

Stanislaw

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free Jia-Ju Bai <baijiaju1990@163.com> - 2016-01-07 13:00 +0100
  Re: [PATCH] iwl4965: Fix a null pointer dereference in  il_tx_queue_free and il_cmd_queue_free Stanislaw Gruszka <sgruszka@redhat.com> - 2016-01-11 13:20 +0100

csiph-web