Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1305997

Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror option

From Sudeep Holla <sudeep.holla@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror option
Date 2016-01-11 11:00 +0100
Message-ID <qPHqz-yo-25@gated-at.bofh.it> (permalink)
References <qOAKu-4aR-7@gated-at.bofh.it> <qOAKu-4aR-17@gated-at.bofh.it> <qOII3-1k3-31@gated-at.bofh.it> <qOOu7-5ka-39@gated-at.bofh.it>
Organization ARM

Show all headers | View raw



On 08/01/16 23:12, Andrew Morton wrote:
> On Fri, 8 Jan 2016 17:02:39 +0000 Sudeep Holla <sudeep.holla@arm.com> wrote:
>
>>> +
>>> +			/*
>>> +			 * if not mirrored_kernelcore and ZONE_MOVABLE exists,
>>> +			 * range from zone_movable_pfn[nid] to end of each node
>>> +			 * should be ZONE_MOVABLE not ZONE_NORMAL. skip it.
>>> +			 */
>>> +			if (!mirrored_kernelcore && zone_movable_pfn[nid])
>>> +				if (zone == ZONE_NORMAL &&
>>> +				    pfn >= zone_movable_pfn[nid])
>>> +					continue;
>>> +
>>
>> I tried this with today's -next, the above lines gave compilation error.
>> Moved them below into HAVE_MEMBLOCK_NODE_MAP and tested it on ARM64.
>> I don't see the previous backtraces. Let me know if that's correct or
>> you can post a version that compiles correctly and I can give a try.
>
> Thanks.   I'll include the below and shall add your tested-by:, OK?
>

Yes this is the exact change I tested. Also I retested your latest patch
set with today's -next. So,

Tested-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 0/2] mm: Introduce kernelcore=mirror option Taku Izumi <izumi.taku@jp.fujitsu.com> - 2016-01-08 09:40 +0100
  [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror option Taku Izumi <izumi.taku@jp.fujitsu.com> - 2016-01-08 09:40 +0100
    Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror  option Sudeep Holla <sudeep.holla@arm.com> - 2016-01-08 18:10 +0100
      Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror  option Andrew Morton <akpm@linux-foundation.org> - 2016-01-09 00:20 +0100
        Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror  option Sudeep Holla <sudeep.holla@arm.com> - 2016-01-11 11:00 +0100
  [PATCH v4 0/2] mm: Introduce kernelcore=mirror option Taku Izumi <izumi.taku@jp.fujitsu.com> - 2016-01-08 09:40 +0100

csiph-web