Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1305847
| From | wanghaibin <wanghaibin.wang@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location. |
| Date | 2016-01-11 06:30 +0100 |
| Message-ID | <qPDdg-6iW-7@gated-at.bofh.it> (permalink) |
| References | <qOiaR-8bd-5@gated-at.bofh.it> <qOiaS-8bd-23@gated-at.bofh.it> <qOkZ3-1DY-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016/1/7 23:48, Tejun Heo wrote: > On Thu, Jan 07, 2016 at 08:38:56PM +0800, wanghaibin wrote: >> the wq_update_unbound_numa_attrs_buf will be useful, only when the >> wq_numa_enabled is true. >> if there is something wrong to cause the wq_numa_enable false, it >> can just return without the wq_update_unbound_numa_attrs_buf >> allocation. >> >> This doesn't introduce any functional changes. > > I don't see what the point is with this change. > What I Meant To Say, if (WARN_ON(node == NUMA_NO_NODE)) is true, this cause wq_numa_enabled to be set the false. That is, the wq_update_unbound_numa_attrs_buf will be useless. It can free the the wq_update_unbound_numa_attrs_buf while the WARN_ON condition is true; Or, better way is that only when the wq_numa_enabled is true, we will allocate the wq_update_unbound_numa_attrs_buf; However, just like your said, the WARN_ON condition should never happen, Maybe this change is not useless too :) . > Thanks. >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 0/4] fixs/suggestions for workqueue subsystem. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
[RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
Re: [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location. Tejun Heo <tj@kernel.org> - 2016-01-07 16:50 +0100
Re: [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-11 06:30 +0100
[RFC PATCH 4/4] workqueue: simplify the apply_workqueue_attrs_locked function. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
[RFC PATCH 4/4] workqueue: simplify the apply_workqueue_attrs_locked function. Tejun Heo <tj@kernel.org> - 2016-01-07 17:10 +0100
[RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
Re: [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device Tejun Heo <tj@kernel.org> - 2016-01-07 17:10 +0100
Re: [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-11 13:30 +0100
[RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed. Tejun Heo <tj@kernel.org> - 2016-01-07 17:00 +0100
Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-11 05:30 +0100
csiph-web