Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1305818
| From | wanghaibin <wanghaibin.wang@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed. |
| Date | 2016-01-11 05:30 +0100 |
| Message-ID | <qPChd-5Gm-39@gated-at.bofh.it> (permalink) |
| References | <qOiaR-8bd-5@gated-at.bofh.it> <qOiaT-8bd-43@gated-at.bofh.it> <qOl8K-1I5-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016/1/7 23:50, Tejun Heo wrote: > On Thu, Jan 07, 2016 at 08:38:57PM +0800, wanghaibin wrote: >> Before the return that wq_numa_init failed, it will be bettet to free >> the numa node table to avoid the memory leaks. > OK, I just expect that it can free the memory in all exception cases! > That's a WARN_ON condition which should never happen. The system is > already pretty messed up and just limping along. It really doesn't > matter whether some memory is cleaned up or not. Let's keep it > simple. OK, get it ! > > Thanks. >
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[RFC PATCH 0/4] fixs/suggestions for workqueue subsystem. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
[RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
Re: [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location. Tejun Heo <tj@kernel.org> - 2016-01-07 16:50 +0100
Re: [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-11 06:30 +0100
[RFC PATCH 4/4] workqueue: simplify the apply_workqueue_attrs_locked function. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
[RFC PATCH 4/4] workqueue: simplify the apply_workqueue_attrs_locked function. Tejun Heo <tj@kernel.org> - 2016-01-07 17:10 +0100
[RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
Re: [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device Tejun Heo <tj@kernel.org> - 2016-01-07 17:10 +0100
Re: [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-11 13:30 +0100
[RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-07 13:50 +0100
Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed. Tejun Heo <tj@kernel.org> - 2016-01-07 17:00 +0100
Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed. wanghaibin <wanghaibin.wang@huawei.com> - 2016-01-11 05:30 +0100
csiph-web