Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305772

Re: [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi

Show all headers | View raw

On Thu, Jan 07, 2016 at 05:05:11PM +0800, Yakir Yang wrote:
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2: None
> 
>  .../devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt         | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
> index 668091f..1cdc627 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt
> @@ -2,7 +2,7 @@ Rockchip specific extensions to the Synopsys Designware HDMI
>  ================================
>  
>  Required properties:
> -- compatible: "rockchip,rk3288-dw-hdmi";
> +- compatible: "rockchip,rk3288-dw-hdmi", "rockchip,rk3229-dw-hdmi";
>  - reg: Physical base address and length of the controller's registers.
>  - clocks: phandle to hdmi iahb and isfr clocks.
>  - clock-names: should be "iahb" "isfr"
> @@ -15,8 +15,10 @@ Required properties:
>    rk3288 platform
>  
>  Optional properties
> +- reg: Physical base address and length of the external HDMI PHY's registers.

This is already required...

>  - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
>  - clocks, clock-names: phandle to the HDMI CEC clock, name should be "cec"
> +		       phandle to the external HDMI PHY clock, name should be "extphy"

Does this change apply to rk3288 or just rk3229? If the latter, you 
should make that clear. The driver needs to allow for old dtb's that 
only have 1 clock.

Based on Philipp's feedback, you also need to add a phys property.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 0/4] Add RK3229 HDMI support Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:00 +0100
  [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:10 +0100
    Re: [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Philipp Zabel <p.zabel@pengutronix.de> - 2016-01-07 11:10 +0100
      Re: [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Yakir Yang <ykk@rock-chips.com> - 2016-01-07 11:20 +0100
        Re: [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Philipp Zabel <p.zabel@pengutronix.de> - 2016-01-07 18:00 +0100
          Re: [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Yakir Yang <ykk@rock-chips.com> - 2016-01-08 10:20 +0100
  [RFC PATCH v2 1/4] drm: dw-hdmi: make it easy to recovery the platform data for platform driver Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:10 +0100
  [RFC PATCH v2 2/4] drm: dw-hdmi: passing the "plat_data" when calling platform mode_valid Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:10 +0100
  [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:10 +0100
    Re: [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi Rob Herring <robh@kernel.org> - 2016-01-11 03:10 +0100
      Re: [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi Yakir Yang <ykk@rock-chips.com> - 2016-01-11 04:50 +0100

csiph-web