Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303737

Re: [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support

Show all headers | View raw

Hi Yakir,

Am Donnerstag, den 07.01.2016, 18:15 +0800 schrieb Yakir Yang:
> Hi Philipp,
> 
> Thanks for your fast respond :)
> 
> On 01/07/2016 06:04 PM, Philipp Zabel wrote:
> > Am Donnerstag, den 07.01.2016, 17:02 +0800 schrieb Yakir Yang:
> >> RK3229 integrate an DesignedWare HDMI2.0 controller and an INNO HDMI2.0 phy,
> >> the max output resolution is 4K.
> >>
> >> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> > It sounds like the INNO HDMI2.0 phy is not necessarily specific to
> > RK3229 but might also appear in other SoCs? If so, I think this should
> > be implemented in a separate phy driver and be used by dw_hdmi-rockchip.
> 
> Do you mean I should create a new phy driver that place in "driver/phy" 
> directly ?

Possibly, yes. The exynos video phys are already there. I have kept the
mediatek dsi/hdmi phys together with the DRM driver, but I suppose I
could move them there, too.

> I have think about this idea, and it would make things much clean. But 
> INNO PHY
> driver need the target pixel clock in drm_display_mode, I didn't find a 
> good way
> to pass this variable to separate phy driver. Do you have some idea ?

We'd need to extend the PHY API for this. For the mediatek phys we have
side-stepped the issue by wiring up the PLL output to the common clock
framework.
I expect besides the pixel clock frequency, it might also be necessary
to inform the PHY about cycles per pixel for deep color modes.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 0/4] Add RK3229 HDMI support Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:00 +0100
  [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:10 +0100
    Re: [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Philipp Zabel <p.zabel@pengutronix.de> - 2016-01-07 11:10 +0100
      Re: [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Yakir Yang <ykk@rock-chips.com> - 2016-01-07 11:20 +0100
        Re: [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Philipp Zabel <p.zabel@pengutronix.de> - 2016-01-07 18:00 +0100
          Re: [RFC PATCH v2 3/4] drm: rockchip: hdmi: add RK3229 HDMI support Yakir Yang <ykk@rock-chips.com> - 2016-01-08 10:20 +0100
  [RFC PATCH v2 1/4] drm: dw-hdmi: make it easy to recovery the platform data for platform driver Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:10 +0100
  [RFC PATCH v2 2/4] drm: dw-hdmi: passing the "plat_data" when calling platform mode_valid Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:10 +0100
  [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi Yakir Yang <ykk@rock-chips.com> - 2016-01-07 10:10 +0100
    Re: [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi Rob Herring <robh@kernel.org> - 2016-01-11 03:10 +0100
      Re: [RFC PATCH v2 4/4] dt-bindings: add document for rk3229-hdmi Yakir Yang <ykk@rock-chips.com> - 2016-01-11 04:50 +0100

csiph-web