Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

Path	csiph.com!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure
Date	Sat, 09 Jan 2016 19:30:01 +0100
Message-ID	<qP6qZ-Rt-1@gated-at.bofh.it> (permalink)
References	<qP6hk-NV-5@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	Nicolas Ferre <nicolas.ferre@atmel.com>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Gortmaker <paul.gortmaker@windriver.com>
X-Original-Date	Sat, 9 Jan 2016 10:29:08 -0800
X-Original-Message-ID	<20160109182908.GB29967@kroah.com>
X-Original-References	<1452363335-2535-1-git-send-email-linux@roeck-us.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1305344

Show key headers only | View raw

On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> If serial/atmel_serial.c is compiled with devicetree enabled, the
> following build error is observed.
> 
> drivers/tty/serial/atmel_serial.c:192:1: warning:
> 	data definition has no type or storage class
> drivers/tty/serial/atmel_serial.c:192:1: error:
> 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> drivers/tty/serial/atmel_serial.c:192:1: warning:
> 	parameter names (without types) in function declaration
> 
> MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
> 
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/tty/serial/atmel_serial.c | 1 +
>  1 file changed, 1 insertion(+)

This hit my tree last night already with commit
041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
next linux-next release.

thanks,

greg k-h

Thread

[PATCH -next] tty/serial: atmel: Include module.h to fix build failure Guenter Roeck <linux@roeck-us.net> - 2016-01-09 19:20 +0100
  Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-01-09 19:30 +0100
    Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-11 09:40 +0100
      Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Guenter Roeck <linux@roeck-us.net> - 2016-01-11 12:20 +0100
        Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-11 12:40 +0100
        Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-01-11 16:10 +0100
          Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Guenter Roeck <linux@roeck-us.net> - 2016-01-13 06:40 +0100
            Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Joe Perches <joe@perches.com> - 2016-01-13 06:50 +0100
              Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-13 11:40 +0100
                Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Guenter Roeck <linux@roeck-us.net> - 2016-01-13 14:10 +0100
                Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Joe Perches <joe@perches.com> - 2016-01-13 16:10 +0100
            Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-13 11:30 +0100

csiph-web