Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305343

[PATCH -next] tty/serial: atmel: Include module.h to fix build failure

From Guenter Roeck <linux@roeck-us.net>
Newsgroups linux.kernel
Subject [PATCH -next] tty/serial: atmel: Include module.h to fix build failure
Date 2016-01-09 19:20 +0100
Message-ID <qP6hk-NV-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw

If serial/atmel_serial.c is compiled with devicetree enabled, the
following build error is observed.

drivers/tty/serial/atmel_serial.c:192:1: warning:
	data definition has no type or storage class
drivers/tty/serial/atmel_serial.c:192:1: error:
	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
drivers/tty/serial/atmel_serial.c:192:1: warning:
	parameter names (without types) in function declaration

MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.

Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/tty/serial/atmel_serial.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 50e785a0ea73..71c385b09db8 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -22,6 +22,7 @@
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  *
  */
+#include <linux/module.h>
 #include <linux/tty.h>
 #include <linux/ioport.h>
 #include <linux/slab.h>
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] tty/serial: atmel: Include module.h to fix build failure Guenter Roeck <linux@roeck-us.net> - 2016-01-09 19:20 +0100
  Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-01-09 19:30 +0100
    Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-11 09:40 +0100
      Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Guenter Roeck <linux@roeck-us.net> - 2016-01-11 12:20 +0100
        Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-11 12:40 +0100
        Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-01-11 16:10 +0100
          Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Guenter Roeck <linux@roeck-us.net> - 2016-01-13 06:40 +0100
            Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Joe Perches <joe@perches.com> - 2016-01-13 06:50 +0100
              Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-13 11:40 +0100
                Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Guenter Roeck <linux@roeck-us.net> - 2016-01-13 14:10 +0100
                Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Joe Perches <joe@perches.com> - 2016-01-13 16:10 +0100
            Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build  failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-13 11:30 +0100

csiph-web