Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1303885

Re: net-thunder: One check less in nicvf_register_interrupts() after error detection

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: net-thunder: One check less in nicvf_register_interrupts() after error detection
Date 2016-01-07 21:50 +0100
Message-ID <qOpFp-4Sh-21@gated-at.bofh.it> (permalink)
References (5 earlier) <qOoT0-4ij-19@gated-at.bofh.it> <qOp2F-4BD-13@gated-at.bofh.it> <qOp2F-4BD-11@gated-at.bofh.it> <qOpm3-4Jn-5@gated-at.bofh.it> <qOpvH-4NZ-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 2016-01-07 at 21:38 +0100, SF Markus Elfring wrote:
> > Some prefer that source code be "templatized" regardless
> > of the number of exit points that any particular use of a
> > specific function type.
[]
> > Some of your patches are converting these templatized
> > functions to a different form for no added value.
> 
> Would you like to distinguish a bit more between my evolving
> collection of update suggestions and the concrete proposal
> for the function "nicvf_register_interrupts"?

No.

> > These patches make the local source code inconsistent
> > and generally goes against the authors preferred style.
> 
> Which programming approach will be the leading one here finally?

Whatever the developer wants.

There is no _best_ or _only_ style for this.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] net-thunder: One check less in  nicvf_register_interrupts() after error detection Robert Richter <rric@kernel.org> - 2016-01-07 12:10 +0100
  Re: [PATCH] net-thunder: One check less in  nicvf_register_interrupts() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-07 20:40 +0100
    Re: [PATCH] net-thunder: One check less in  nicvf_register_interrupts() after error detection Joe Perches <joe@perches.com> - 2016-01-07 20:50 +0100
      Re: net-thunder: One check less in nicvf_register_interrupts() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-07 21:00 +0100
        Re: net-thunder: One check less in nicvf_register_interrupts() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-07 21:10 +0100
          Re: net-thunder: One check less in nicvf_register_interrupts()  after error detection Joe Perches <joe@perches.com> - 2016-01-07 21:30 +0100
            Re: net-thunder: One check less in nicvf_register_interrupts() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-07 21:40 +0100
              Re: net-thunder: One check less in nicvf_register_interrupts()  after error detection Joe Perches <joe@perches.com> - 2016-01-07 21:50 +0100
        Re: net-thunder: One check less in nicvf_register_interrupts()  after error detection Joe Perches <joe@perches.com> - 2016-01-07 21:10 +0100

csiph-web