Re: net-thunder: One check less in nicvf_register_interrupts() after error detection

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: net-thunder: One check less in nicvf_register_interrupts() after error detection
Date	2016-01-07 21:10 +0100
Message-ID	<qOp2F-4BD-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <qLTgB-1mT-1@gated-at.bofh.it> <qOgC5-7hc-5@gated-at.bofh.it> <qOozE-4bb-3@gated-at.bofh.it> <qOoJk-4eE-13@gated-at.bofh.it> <qOoT0-4ij-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-01-07 at 20:56 +0100, SF Markus Elfring wrote:
> > > Is it a bit more efficient to avoid a double check for the
> > > variable "ret" at the end of the current implementation for the
> > > discussed function?
> > 
> > Before asking questions you could answer yourself,
> > please look at object code produced by the compiler
> > before and after your proposed changes.
> 
> * Do any more source code reviewers wonder about the need
>   for such a double check?

Given the feedback you've already received,
it seems so.

> * Which object code representations would you find representative
>   for a further constructive discussion around this
>   software component?

Evidence of actual object code improvement when
with compiled with optimizations.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] net-thunder: One check less in  nicvf_register_interrupts() after error detection Robert Richter <rric@kernel.org> - 2016-01-07 12:10 +0100
  Re: [PATCH] net-thunder: One check less in  nicvf_register_interrupts() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-07 20:40 +0100
    Re: [PATCH] net-thunder: One check less in  nicvf_register_interrupts() after error detection Joe Perches <joe@perches.com> - 2016-01-07 20:50 +0100
      Re: net-thunder: One check less in nicvf_register_interrupts() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-07 21:00 +0100
        Re: net-thunder: One check less in nicvf_register_interrupts() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-07 21:10 +0100
          Re: net-thunder: One check less in nicvf_register_interrupts()  after error detection Joe Perches <joe@perches.com> - 2016-01-07 21:30 +0100
            Re: net-thunder: One check less in nicvf_register_interrupts() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-07 21:40 +0100
              Re: net-thunder: One check less in nicvf_register_interrupts()  after error detection Joe Perches <joe@perches.com> - 2016-01-07 21:50 +0100
        Re: net-thunder: One check less in nicvf_register_interrupts()  after error detection Joe Perches <joe@perches.com> - 2016-01-07 21:10 +0100

csiph-web