Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1303794

[PATCH 5/8] [media] tvp514x: Check v4l2_of_parse_endpoint() return value

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject [PATCH 5/8] [media] tvp514x: Check v4l2_of_parse_endpoint() return value
Date 2016-01-07 19:30 +0100
Message-ID <qOntW-3ug-59@gated-at.bofh.it> (permalink)
References <qOntU-3ug-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The v4l2_of_parse_endpoint() function can fail so check the return value.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/media/i2c/tvp514x.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c
index 7fa5f1e4fe37..7a1e20feade9 100644
--- a/drivers/media/i2c/tvp514x.c
+++ b/drivers/media/i2c/tvp514x.c
@@ -1013,11 +1013,13 @@ tvp514x_get_pdata(struct i2c_client *client)
 	if (!endpoint)
 		return NULL;
 
+	if (v4l2_of_parse_endpoint(endpoint, &bus_cfg))
+		goto done;
+
 	pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
 	if (!pdata)
 		goto done;
 
-	v4l2_of_parse_endpoint(endpoint, &bus_cfg);
 	flags = bus_cfg.bus.parallel.flags;
 
 	if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH)
-- 
2.4.3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-07 19:30 +0100
  [PATCH 5/8] [media] tvp514x: Check v4l2_of_parse_endpoint() return value Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-07 19:30 +0100
    Re: [PATCH 5/8] [media] tvp514x: Check v4l2_of_parse_endpoint()  return value Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-10 00:10 +0100
  [PATCH 6/8] [media] tvp7002: Check v4l2_of_parse_endpoint() return value Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-07 19:40 +0100
    Re: [PATCH 6/8] [media] tvp7002: Check v4l2_of_parse_endpoint()  return value Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-10 00:10 +0100
  Re: [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in  all drivers Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-10 00:10 +0100
    Re: [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all  drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-11 17:50 +0100

csiph-web