[PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers
Date	2016-01-07 19:30 +0100
Message-ID	<qOntU-3ug-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

When discussing a patch [0] with Laurent Pinchart for another series I
mentioned to him that most callers of v4l2_of_parse_endpoint() weren't
checking the return value. This is likely due the function kernel-doc
stating incorrectly that the return value is always 0 but can return a
negative error code on failure.

This trivial patch series fixes the function kernel-doc and add proper
error checking in all the drivers that are currently not doing so.

[0]: https://lkml.org/lkml/2016/1/6/307

Best regards,
Javier


Javier Martinez Canillas (8):
  [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc
  [media] adv7604: Check v4l2_of_parse_endpoint() return value
  [media] s5c73m3: Check v4l2_of_parse_endpoint() return value
  [media] s5k5baf: Check v4l2_of_parse_endpoint() return value
  [media] tvp514x: Check v4l2_of_parse_endpoint() return value
  [media] tvp7002: Check v4l2_of_parse_endpoint() return value
  [media] exynos4-is: Check v4l2_of_parse_endpoint() return value
  [media] omap3isp: Check v4l2_of_parse_endpoint() return value

 drivers/media/i2c/adv7604.c                   |  7 ++++++-
 drivers/media/i2c/s5c73m3/s5c73m3-core.c      |  4 +++-
 drivers/media/i2c/s5k5baf.c                   |  5 ++++-
 drivers/media/i2c/tvp514x.c                   |  4 +++-
 drivers/media/i2c/tvp7002.c                   |  4 +++-
 drivers/media/platform/exynos4-is/media-dev.c |  8 +++++++-
 drivers/media/platform/exynos4-is/mipi-csis.c | 10 +++++++---
 drivers/media/platform/omap3isp/isp.c         |  5 ++++-
 drivers/media/v4l2-core/v4l2-of.c             |  2 +-
 9 files changed, 38 insertions(+), 11 deletions(-)

-- 
2.4.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-07 19:30 +0100
  [PATCH 5/8] [media] tvp514x: Check v4l2_of_parse_endpoint() return value Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-07 19:30 +0100
    Re: [PATCH 5/8] [media] tvp514x: Check v4l2_of_parse_endpoint()  return value Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-10 00:10 +0100
  [PATCH 6/8] [media] tvp7002: Check v4l2_of_parse_endpoint() return value Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-07 19:40 +0100
    Re: [PATCH 6/8] [media] tvp7002: Check v4l2_of_parse_endpoint()  return value Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-10 00:10 +0100
  Re: [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in  all drivers Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-10 00:10 +0100
    Re: [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all  drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-11 17:50 +0100

csiph-web