Re: 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online()

From	Ursula Braun <ubraun@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online()
Date	2016-01-08 09:30 +0100
Message-ID	<qOAAN-45F-5@gated-at.bofh.it> (permalink)
References	<qEuGl-43C-5@gated-at.bofh.it> <qMNLQ-40q-9@gated-at.bofh.it> <qMNLQ-40q-13@gated-at.bofh.it> <qOjTk-SP-13@gated-at.bofh.it> <qOzv3-3m3-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-01-08 at 08:18 +0100, SF Markus Elfring wrote:
> > As Heiko already answered, you could propose a lot of this kind of changes
> > with just minor benefit. I do not want to push them in single patches.
> 
> Thanks for your clarification.
> 
> 
> > Either there is a cleanup patch for explicit initialisation of
> > local variables in the whole qeth driver,
> 
> Is there any more fine-tuning cooking in the background?
Not yet; qeth is an important driver for Linux on System z; there are
lots of investigation ideas for improvements, which we will take care
about according to their priorities. I regard your proposed fine-tuning
code change as valid, but prioritize it as one with lowest benefit,
since it does not really make a difference once compiled.
> 
> 
> > or we take care about such minor changes, once we touch the code anyway
> 
> How often will this really happen?
There is no general rule. Check our git history to answer this question.
> 
> 
> > due to other reasons.
> 
> I am curious which ones will trigger further related software improvements.
> 
> Regards,
> Markus
>

Thread

[PATCH 0/2] 390/qeth: Fine-tuning for qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 11:10 +0100
  [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation  in qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 11:10 +0100
    Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable  initialisation in qeth_core_set_online() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-04 12:30 +0100
    Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable  initialisation in qeth_core_set_online() Ursula Braun <ubraun@linux.vnet.ibm.com> - 2016-01-07 15:40 +0100
      Re: 390/qeth: Delete an unnecessary variable initialisation in  qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-08 08:20 +0100
        Re: 390/qeth: Delete an unnecessary variable initialisation in  qeth_core_set_online() Ursula Braun <ubraun@linux.vnet.ibm.com> - 2016-01-08 09:30 +0100
          Re: 390/qeth: Delete an unnecessary variable initialisation in  qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-08 13:10 +0100
  [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 11:10 +0100
    Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-04 12:40 +0100
      Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 14:20 +0100
        Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-04 15:10 +0100
          Re: 390/qeth: Refactoring for qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 15:20 +0100
            Re: 390/qeth: Refactoring for qeth_core_set_online() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-05 09:00 +0100

csiph-web