Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300647

Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online()

Show all headers | View raw

On Sun, Jan 03, 2016 at 11:02:00AM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 3 Jan 2016 10:48:05 +0100
> 
> Omit explicit initialisation at the beginning for one local variable
> that is redefined before its first use.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/s390/net/qeth_core_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 7871537..54fde2e 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -5637,7 +5637,7 @@ static void qeth_core_remove_device(struct ccwgroup_device *gdev)
>  static int qeth_core_set_online(struct ccwgroup_device *gdev)
>  {
>  	struct qeth_card *card = dev_get_drvdata(&gdev->dev);
> -	int rc = 0;
> +	int rc;
>  	int def_discipline;

You can generate hundreds of patches like this one. There are even plenty
more opportunities within this same file. I don't think we need this.

If at all then change all occurrences within a file at once, but that is
Ursula's call.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] 390/qeth: Fine-tuning for qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 11:10 +0100
  [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation  in qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 11:10 +0100
    Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable  initialisation in qeth_core_set_online() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-04 12:30 +0100
    Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable  initialisation in qeth_core_set_online() Ursula Braun <ubraun@linux.vnet.ibm.com> - 2016-01-07 15:40 +0100
      Re: 390/qeth: Delete an unnecessary variable initialisation in  qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-08 08:20 +0100
        Re: 390/qeth: Delete an unnecessary variable initialisation in  qeth_core_set_online() Ursula Braun <ubraun@linux.vnet.ibm.com> - 2016-01-08 09:30 +0100
          Re: 390/qeth: Delete an unnecessary variable initialisation in  qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-08 13:10 +0100
  [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 11:10 +0100
    Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-04 12:40 +0100
      Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 14:20 +0100
        Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-04 15:10 +0100
          Re: 390/qeth: Refactoring for qeth_core_set_online() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 15:20 +0100
            Re: 390/qeth: Refactoring for qeth_core_set_online() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-05 09:00 +0100

csiph-web