Re: [PATCH v2 net-next] ethernet/atheros/alx: sanitize buffer sizing and padding

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 net-next] ethernet/atheros/alx: sanitize buffer sizing and padding
Date	Wed, 06 Jan 2016 21:10:01 +0100
Message-ID	<qO2z7-5S9-11@gated-at.bofh.it> (permalink)
References	<qNPLz-5Qn-5@gated-at.bofh.it> <qNXpM-2lM-19@gated-at.bofh.it>
X-Mailer	Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=us-ascii
Content-Transfer-Encoding	7bit
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Jan 2016 12:05:41 -0800 (PST)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, eugene.shatokhin@rosalab.ru, prudy1@o2.pl, jcliburn@gmail.com, chris.snook@gmail.com, netdev@vger.kernel.org
X-Original-Date	Wed, 06 Jan 2016 15:05:39 -0500 (EST)
X-Original-Message-ID	<20160106.150539.179421707935774818.davem@davemloft.net>
X-Original-References	<20160106.012326.1058946039396006074.davem@davemloft.net> <1452090997-27683-1-git-send-email-jarod@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1303036

Show key headers only | View raw

From: Jarod Wilson <jarod@redhat.com>
Date: Wed,  6 Jan 2016 09:36:37 -0500

> This is based on the work done by Przemek Rudy in bug 70761 at
> bugzilla.kernel.org, but with some work done to disentagle and clarify
> things a bit.
> 
> Similar to Przemek's work and other drivers, we're adding a padding of 16
> here, but we're also disentangling mtu size calculations from max buffer
> size calculations a bit, and adding ETH_HLEN to the value written into
> ALX_MTU. Hopefully, with a bit more consistency and clarity, things behave
> better here. Sadly, I can only test in my alx-driven E2200, which worked
> just fine before this patch.
> 
> In comment #58 of bug 70761, Eugene A. Shatokhin reports that this patch
> does help considerably for a ROSA Linux user of his with an AR8162 network
> adapter when patched into a 4.1.x-based kernel, with several days of
> normal operation where wired network previously wasn't usable without
> setting MTU to 9000 as a work-around.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70761
> CC: "Eugene A. Shatokhin" <eugene.shatokhin@rosalab.ru>
> CC: Przemek Rudy <prudy1@o2.pl>
> CC: Jay Cliburn <jcliburn@gmail.com>
> CC: Chris Snook <chris.snook@gmail.com>
> CC: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
> v2: remove superfluous parens around raw_mtu, pointed out by davem

Looks great, applied, thanks Jarod.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing and padding Jarod Wilson <jarod@redhat.com> - 2016-01-06 00:20 +0100
  Re: [PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing  and padding David Miller <davem@davemloft.net> - 2016-01-06 07:30 +0100
    [PATCH v2 net-next] ethernet/atheros/alx: sanitize buffer sizing and padding Jarod Wilson <jarod@redhat.com> - 2016-01-06 15:40 +0100
      Re: [PATCH v2 net-next] ethernet/atheros/alx: sanitize buffer  sizing and padding David Miller <davem@davemloft.net> - 2016-01-06 21:10 +0100

csiph-web