Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303036

Re: [PATCH v2 net-next] ethernet/atheros/alx: sanitize buffer sizing and padding

Show all headers | View raw

From: Jarod Wilson <jarod@redhat.com>
Date: Wed,  6 Jan 2016 09:36:37 -0500

> This is based on the work done by Przemek Rudy in bug 70761 at
> bugzilla.kernel.org, but with some work done to disentagle and clarify
> things a bit.
> 
> Similar to Przemek's work and other drivers, we're adding a padding of 16
> here, but we're also disentangling mtu size calculations from max buffer
> size calculations a bit, and adding ETH_HLEN to the value written into
> ALX_MTU. Hopefully, with a bit more consistency and clarity, things behave
> better here. Sadly, I can only test in my alx-driven E2200, which worked
> just fine before this patch.
> 
> In comment #58 of bug 70761, Eugene A. Shatokhin reports that this patch
> does help considerably for a ROSA Linux user of his with an AR8162 network
> adapter when patched into a 4.1.x-based kernel, with several days of
> normal operation where wired network previously wasn't usable without
> setting MTU to 9000 as a work-around.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70761
> CC: "Eugene A. Shatokhin" <eugene.shatokhin@rosalab.ru>
> CC: Przemek Rudy <prudy1@o2.pl>
> CC: Jay Cliburn <jcliburn@gmail.com>
> CC: Chris Snook <chris.snook@gmail.com>
> CC: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
> v2: remove superfluous parens around raw_mtu, pointed out by davem

Looks great, applied, thanks Jarod.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing and padding Jarod Wilson <jarod@redhat.com> - 2016-01-06 00:20 +0100
  Re: [PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing  and padding David Miller <davem@davemloft.net> - 2016-01-06 07:30 +0100
    [PATCH v2 net-next] ethernet/atheros/alx: sanitize buffer sizing and padding Jarod Wilson <jarod@redhat.com> - 2016-01-06 15:40 +0100
      Re: [PATCH v2 net-next] ethernet/atheros/alx: sanitize buffer  sizing and padding David Miller <davem@davemloft.net> - 2016-01-06 21:10 +0100

csiph-web