Re: [PATCH 2/2] drm: bridge: add sil902x DT bindings doc

Path	csiph.com!news.mixmin.net!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] drm: bridge: add sil902x DT bindings doc
Date	Wed, 06 Jan 2016 14:30:02 +0100
Message-ID	<qNWk2-1HB-23@gated-at.bofh.it> (permalink)
References	<qNUrU-sc-5@gated-at.bofh.it> <qNUrU-sc-3@gated-at.bofh.it> <qNWk2-1HB-7@gated-at.bofh.it>
X-Original-To	Rob Herring <robh@kernel.org>
X-Mailer	Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	73
Organization	linux.* mail to news gateway
X-Original-Cc	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, devicetree@vger.kernel.org, Nicolas Ferre <nicolas.ferre@atmel.com>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 6 Jan 2016 14:24:57 +0100
X-Original-Message-ID	<20160106142457.28c8af15@bbrezillon>
X-Original-References	<1452079551-30914-1-git-send-email-boris.brezillon@free-electrons.com> <1452079551-30914-2-git-send-email-boris.brezillon@free-electrons.com> <20160106131959.GA18121@rob-hp-laptop>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1302762

Show key headers only | View raw

Hi Rob,

On Wed, 6 Jan 2016 07:19:59 -0600
Rob Herring <robh@kernel.org> wrote:

> On Wed, Jan 06, 2016 at 12:25:51PM +0100, Boris Brezillon wrote:
> > Add Sil9022 DT bindings description.
> > 
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > ---
> >  .../devicetree/bindings/display/bridge/sil902x.txt | 31 ++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/bridge/sil902x.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/sil902x.txt b/Documentation/devicetree/bindings/display/bridge/sil902x.txt
> > new file mode 100644
> > index 0000000..7f1339f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/sil902x.txt
> > @@ -0,0 +1,31 @@
> > +sil902x HDMI bridge bindings
> > +
> > +Required properties:
> > +	- compatible: "sil,sil9022"
> > +	- reg: i2c address of the bridge
> > +	- reset-gpios: OF device-tree gpio specification for RST_N pin.
> > +
> > +Optional properties:
> > +	- interrupts-extended or interrupt-parent + interrupts: describe
> > +	  the interrupt line used to inform the host about hotplug events.
> > +
> > +Optional subnodes:
> > +	- video input: Device node can contain video input port node to
> > +	  connect the bridge to a display controller output (See this
> > +	  documentation [1]).
> > +
> > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> > +
> > +Example:
> > +	hdmi-bridge@39 {
> > +		compatible = "sil,sil9022";
> > +		reg = <0x39>;
> > +		reset-gpios = <&gpx1 5 1 0 0>;
> 
> 4 GPIO cells? Valid, but unusual.

Hehe, I blindly copied nxp,ptn3460 doc, which is defining such GPIO
descriptors :-). I can change that if you want.

> 
> > +		ports {
> > +			port@0 {
> 
> Either need a reg property here or drop the unit address. You could 
> remove ports as well.

Actually we'll likely define a 2nd port for the audio input, so I'd
prefer keeping the ports and @0 suffix and adding a reg property rather
than just defining port { ... };

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] drm: bridge: add sil902x DT bindings doc Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-01-06 12:30 +0100
  Re: [PATCH 2/2] drm: bridge: add sil902x DT bindings doc Rob Herring <robh@kernel.org> - 2016-01-06 14:30 +0100
    Re: [PATCH 2/2] drm: bridge: add sil902x DT bindings doc Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-01-06 14:30 +0100

csiph-web