Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Javi Merino <javi.merino@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power
Date	Wed, 06 Jan 2016 11:10:02 +0100
Message-ID	<qNTcu-87B-5@gated-at.bofh.it> (permalink)
References	<qNS6J-7dw-7@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	Jonathan Corbet <corbet@lwn.net>, Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>, Punit Agrawal <punit.agrawal@arm.com>, Daniel Kurtz <djkurtz@chromium.org>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Daniel Thompson <daniel.thompson@linaro.org>
X-Original-Date	Wed, 6 Jan 2016 10:07:13 +0000
X-Original-Message-ID	<20160106100712.GA2790@e104805>
X-Original-References	<1452070428-2567-1-git-send-email-leo.yan@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1302515

Show key headers only | View raw

On Wed, Jan 06, 2016 at 04:53:44PM +0800, Leo Yan wrote:
> k_po/k_pu are two proportional term constants and essentially they have
> fixed ratio compared with sustainable power. In current implementation,
> k_po and k_pu are absolute value after calculation and cannot represent
> the ratio relationship with sustainable power; as a result, when change
> sustainable power we cannot smoothly change proportional term constant.

In v2 Daniel said that the use case was made up.  Can you elaborate on
why we need this?

> So this patch series introduces k_po_ratio and k_pu_ratio, which
> represent the ratio value compared against sustainable power. Also add
> sys file system nodes for them for easily update them from userspace and
> update a bit in documentation.

Actually, it makes it harder to update from userspace.  Now userspace
can't set a k_po/k_pu any more, and it's forced to set them as ratios
of sustainable power. I'd rather not do this unless there is a good
reason for it.

Cheers,
Javi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power Leo Yan <leo.yan@linaro.org> - 2016-01-06 10:00 +0100
  [PATCH v3 2/4] thermal: power_allocator: change k_pu_ratio/k_po_ratio as percentage Leo Yan <leo.yan@linaro.org> - 2016-01-06 10:00 +0100
  [PATCH v3 4/4] thermal: power_allocator: document k_pu_ratio/k_po_ratio Leo Yan <leo.yan@linaro.org> - 2016-01-06 10:00 +0100
  [PATCH v3 1/4] thermal: power_allocator: rework proportional parameter Leo Yan <leo.yan@linaro.org> - 2016-01-06 10:00 +0100
  [PATCH v3 3/4] thermal: add sys node for k_pu_ratio/k_po_ratio Leo Yan <leo.yan@linaro.org> - 2016-01-06 10:00 +0100
  Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update  sustainable power Javi Merino <javi.merino@arm.com> - 2016-01-06 11:10 +0100
    Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update  sustainable power Leo Yan <leo.yan@linaro.org> - 2016-01-06 12:20 +0100
    Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update  sustainable power Daniel Thompson <daniel.thompson@linaro.org> - 2016-01-06 12:30 +0100
      Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update  sustainable power Javi Merino <javi.merino@arm.com> - 2016-01-06 16:10 +0100

csiph-web