Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301745

Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X

Show all headers | View raw

On Tue, Jan 05, 2016 at 05:36:47PM +0100, Daniel Borkmann wrote:
> On 01/05/2016 04:23 PM, Rabin Vincent wrote:
> >The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data
> >instructions since it XORs A with X while all the others replace A with
> >some loaded value.  All the BPF JITs fail to clear A if this is used as
> >the first instruction in a filter.  This was found using american fuzzy
> >lop.
> >
> >Add a helper to determine if A needs to be cleared given the first
> >instruction in a filter, and use this in the JITs.  Except for ARM, the
> >rest have only been compile-tested.
> >
> >Fixes: 3480593131e0 ("net: filter: get rid of BPF_S_* enum")
> >Signed-off-by: Rabin Vincent <rabin@rab.in>
> 
> Excellent catch, thanks a lot! The fix looks good to me and should
> go to -net tree.
> 
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>

good catch indeed.
Classic bpf jits didn't have much love. Great to see this work.

Acked-by: Alexei Starovoitov <ast@kernel.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X Rabin Vincent <rabin@rab.in> - 2016-01-05 16:30 +0100
  Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-05 17:10 +0100
    Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X Rabin Vincent <rabin@rab.in> - 2016-01-05 17:10 +0100
      Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X Daniel Borkmann <daniel@iogearbox.net> - 2016-01-05 17:40 +0100
  Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X Daniel Borkmann <daniel@iogearbox.net> - 2016-01-05 17:40 +0100
    Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-01-05 18:50 +0100
  Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X David Miller <davem@davemloft.net> - 2016-01-06 06:50 +0100

csiph-web