Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

From	Paul Gortmaker <paul.gortmaker@windriver.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular
Date	2016-01-05 17:10 +0100
Message-ID	<qNClk-5bm-15@gated-at.bofh.it> (permalink)
References	<qNiZk-7GT-1@gated-at.bofh.it> <qNmzU-1JR-11@gated-at.bofh.it> <qNmJA-1Nj-25@gated-at.bofh.it> <qNpxL-3Lr-1@gated-at.bofh.it> <qNpHs-3OS-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular] On 05/01/2016 (Tue 11:31) Masahiro Yamada wrote:

> 2016-01-05 11:26 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > Hi Paul,
> >

[...]

> >
> >
> > I assume commit 326ea45aa827 ("bus: uniphier: allow only built-in driver")
> > is a temporary fix.
> >
> > I'd like to revive the tristate for this driver
> > by hook or by crook.
> >
> >
> > I've sent the following to fix the build error.
> > http://www.thefreedictionary.com/
> 
> Sorry, I mean this one:
> https://patchwork.kernel.org/patch/7952361/

Sure, I'll shelf it and assume it will get back to tristate.

Note however that the patch I was looking at was not 326ea. It was

commit 6c741c74092c61465af206672ba567940a23d709
Author: Daniel Kurtz <djkurtz@chromium.org>
Date:   Tue Dec 22 21:46:37 2015 +0800

    pinctrl: mediatek: convert to arch_initcall

..and if you make it tristate again, you defeat the above change,
since if you look at module.h, you will see for the =m config:

 #define arch_initcall(fn)               module_init(fn)

...meaning that the change in 6c741c does nothing if =m is set.
I don't know if that is an issue or not, perhaps Daniel can comment.

Paul.
--

> 
> 
> 
> -- 
> Best Regards
> Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-01-04 20:30 +0100
  Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-05 00:20 +0100
    Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-05 00:30 +0100
      Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-05 03:30 +0100
        Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-05 03:40 +0100
          Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-01-05 17:10 +0100

csiph-web