Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()
Date	2016-01-02 09:20 +0100
Message-ID	<qMpzQ-5Go-1@gated-at.bofh.it> (permalink)
References	<qEuGl-43C-5@gated-at.bofh.it> <qMfAu-7JT-15@gated-at.bofh.it> <qMh9g-ms-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> Move the jump label directly before the desired log statement
>> so that the variable "err" will not be checked once more
>> after it was determined that a function call failed.
>> Use the identifier "report_failure" instead of the label "err".
> 
>    Why?

I suggest to reconsider the places with which such a jump label
is connected.


> The code was smart enough

Which action should really be performed after a failure was detected
and handled a bit already?

* Another condition check

* Just additional error logging


> and you're making it uglier that it needs to be.

I assume that a software development taste can evolve, can't it?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-01 22:40 +0100
  Re: [PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() Julia Lawall <julia.lawall@lip6.fr> - 2016-01-01 22:50 +0100
  Re: [PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-01-02 00:20 +0100
    Re: [PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 09:20 +0100
      Re: [PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() Julia Lawall <julia.lawall@lip6.fr> - 2016-01-02 09:30 +0100
        Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 10:20 +0100
          Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() Arend van Spriel <aspriel@gmail.com> - 2016-01-02 11:20 +0100
            Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 12:30 +0100
              Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() Arend van Spriel <aspriel@gmail.com> - 2016-01-03 10:40 +0100
                Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 13:20 +0100
                Re: net-libertas: Better exception handling in if_spi_host_to_card_worker() Rafał Miłecki <zajec5@gmail.com> - 2016-01-03 16:20 +0100
                Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() Arend van Spriel <aspriel@gmail.com> - 2016-01-04 11:10 +0100
                Re: net-libertas: Better exception handling in if_spi_host_to_card_worker() Rafał Miłecki <zajec5@gmail.com> - 2016-01-04 12:20 +0100

csiph-web