Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300290

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

Show all headers | View raw

>>> What the patch tries to do is avoid the extra 'if (err)'.
>>
>> Yes. - I propose to look at related consequences together with the usage
>> of a popular short jump label once more.
> 
> When I read a subject saying "Better exception handling" it sounds like
> a functional improvement. Your change does not change anything
> functionally and may or may not save a bit of execution time depending
> on how smart the compiler is.

Can it eventually matter to skip another condition check in three cases?


> What you change does is confuse people reading the code.

A few software developers might find this proposal unusual.


> So please explain why your update improves exception handling here.
> I don't see it.

How does this feedback fit to the mentioned check avoidance?


> The code is not making the driver more robust against failures

That's true for this update suggestion.


> in this function, which is what I think of reading "better exception handling".

Other implementation details are affected by the shown fine-tuning.

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-01 22:40 +0100
  Re: [PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() Julia Lawall <julia.lawall@lip6.fr> - 2016-01-01 22:50 +0100
  Re: [PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-01-02 00:20 +0100
    Re: [PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 09:20 +0100
      Re: [PATCH] net-libertas: Better exception handling in  if_spi_host_to_card_worker() Julia Lawall <julia.lawall@lip6.fr> - 2016-01-02 09:30 +0100
        Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 10:20 +0100
          Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() Arend van Spriel <aspriel@gmail.com> - 2016-01-02 11:20 +0100
            Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 12:30 +0100
              Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() Arend van Spriel <aspriel@gmail.com> - 2016-01-03 10:40 +0100
                Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-03 13:20 +0100
                Re: net-libertas: Better exception handling in if_spi_host_to_card_worker() Rafał Miłecki <zajec5@gmail.com> - 2016-01-03 16:20 +0100
                Re: net-libertas: Better exception handling in  if_spi_host_to_card_worker() Arend van Spriel <aspriel@gmail.com> - 2016-01-04 11:10 +0100
                Re: net-libertas: Better exception handling in if_spi_host_to_card_worker() Rafał Miłecki <zajec5@gmail.com> - 2016-01-04 12:20 +0100

csiph-web