Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

From	Paul Kocialkowski <contact@paulk.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support
Date	2016-01-03 11:20 +0100
Message-ID	<qMNVv-43K-1@gated-at.bofh.it> (permalink)
References	(6 earlier) <qLrX4-z9-21@gated-at.bofh.it> <qLtPc-1Kb-15@gated-at.bofh.it> <qLTqi-1q8-7@gated-at.bofh.it> <qLTqi-1q8-5@gated-at.bofh.it> <qLTJF-1Mv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Le jeudi 31 décembre 2015 à 22:14 +0000, Mark Brown a écrit :
> On Thu, Dec 31, 2015 at 10:59:06PM +0100, Paul Kocialkowski wrote:
> 
> > I understand, thanks for pointing this out. Well, for my use case, there
> > is no use in disabling the chip at any point as it powers the external
> > mmc.
> 
> Presumably someone might decide not to use the MMC in some case (perhaps
> only mounting it when explicitly needed in order to save power for
> example, or the MMC subsystem might figure out a way to power down an
> idle MMC block device).

Makes sense, I'll keep that in mind.

> > Would you agree to have the enable pin handled directly (and by that, I
> > mean enabled once, when requested, as I first suggested in the patchset)
> > in the driver then?
> 
> That's probably fine, or do it via runtime PM (the framework is fairly
> simple to use, I'll probably go add support in the core for it in the
> next day or two as this seems like a sensible use case).  I can't
> remember if this device is a MFD or not and I'm just on my way out the
> door.

Runtime PM seems like a good fit (though I hadn't heard about it before:
you can guess I'm fairly new to kernel development), please let me know
whether you end up implementing it so I can try to handle the GPIO this
way.

Thanks!

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: https://www.replicant.us/
Blog: https://blog.replicant.us/
Wiki/tracker/forums: https://redmine.replicant.us/

Thread

[PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
  [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
    Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS  GPIO Mark Brown <broonie@kernel.org> - 2015-12-23 12:50 +0100
      Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS  GPIO Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 13:00 +0100
        Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS  GPIO Mark Brown <broonie@kernel.org> - 2015-12-23 13:00 +0100
  [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
    Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-23 13:00 +0100
      Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 14:00 +0100
      Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-24 19:20 +0100
        Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-24 20:40 +0100
          Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-24 21:10 +0100
      Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-28 03:50 +0100
        Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-29 00:00 +0100
          Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-29 01:50 +0100
            Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-29 12:20 +0100
              Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-30 01:30 +0100
                Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-30 09:40 +0100
                Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-30 17:40 +0100
                Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-30 19:40 +0100
                Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-31 23:00 +0100
                Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-31 23:20 +0100
                Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2016-01-03 11:20 +0100
                Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-31 23:00 +0100
    Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-28 03:50 +0100
    Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Rob Herring <robh@kernel.org> - 2015-12-29 21:10 +0100
      Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-29 22:30 +0100
        Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Rob Herring <robh@kernel.org> - 2015-12-29 23:00 +0100
  [PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
  [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
    Applied "regulator: lp872x: Get rid of duplicate reference to DVS GPIO" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-12-23 13:20 +0100
    Re: [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to  DVS GPIO Milo Kim <milo.kim@ti.com> - 2015-12-28 03:50 +0100

csiph-web