Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1299453
| From | Paul Kocialkowski <contact@paulk.fr> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support |
| Date | 2015-12-30 19:40 +0100 |
| Message-ID | <qLtPc-1Kb-15@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <qKQEa-1iO-3@gated-at.bofh.it> <qL0tQ-85s-15@gated-at.bofh.it> <qLcOl-7E2-7@gated-at.bofh.it> <qLksy-4dr-11@gated-at.bofh.it> <qLrX4-z9-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Le mercredi 30 décembre 2015 à 16:33 +0000, Mark Brown a écrit : > On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: > > > In my opinion, it would be more elegant to adapt the core regulator > > framework to first enable the GPIO and then call the regulator enable > > ops callback instead of handling the GPIO in the driver. > > Why would we want to actively manage both things at runtime? It's more > work, what do we gain from it? Well, I figured that it would be best to disable the EN pin when we're not using any of the regulators, since that allows the chip to enter standby mode (and thus consume less power). Implementing that logic in the driver seems very redundant when we're one step away from doing it with the core regulator framework. It is also likely that in the future, other chips will use and need to handle a global enable pin for the same purpose, while allowing regulator configuration and enable via registers. It also doesn't hurt regulators that only use a GPIO for enable. The diff to do this is very minimal, I already have a patch ready, that I could send if there is a chance for it to get through. -- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution running on several devices, a free software mobile operating system putting the emphasis on freedom and privacy/security. Website: https://www.replicant.us/ Blog: https://blog.replicant.us/ Wiki/tracker/forums: https://redmine.replicant.us/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
[PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO Mark Brown <broonie@kernel.org> - 2015-12-23 12:50 +0100
Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 13:00 +0100
Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO Mark Brown <broonie@kernel.org> - 2015-12-23 13:00 +0100
[PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-23 13:00 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 14:00 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-24 19:20 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-24 20:40 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-24 21:10 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-28 03:50 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-29 00:00 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-29 01:50 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-29 12:20 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-30 01:30 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-30 09:40 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-30 17:40 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-30 19:40 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-31 23:00 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-31 23:20 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Mark Brown <broonie@kernel.org> - 2015-12-31 23:00 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Milo Kim <milo.kim@ti.com> - 2015-12-28 03:50 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Rob Herring <robh@kernel.org> - 2015-12-29 21:10 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski <contact@paulk.fr> - 2015-12-29 22:30 +0100
Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Rob Herring <robh@kernel.org> - 2015-12-29 23:00 +0100
[PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
[PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Paul Kocialkowski <contact@paulk.fr> - 2015-12-23 12:10 +0100
Applied "regulator: lp872x: Get rid of duplicate reference to DVS GPIO" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-12-23 13:20 +0100
Re: [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Milo Kim <milo.kim@ti.com> - 2015-12-28 03:50 +0100
csiph-web