Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction
Date	2015-12-30 14:30 +0100
Message-ID	<qLoZb-79S-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <qDPDc-2e2-7@gated-at.bofh.it> <qDQfX-2uA-81@gated-at.bofh.it> <qDQpz-2N1-11@gated-at.bofh.it> <qDQzf-2Qo-9@gated-at.bofh.it> <qLoZb-79S-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 30, 2015 at 3:23 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
> On 12/9/2015 12:14 PM, Christopher Covington wrote:
>>> On 12/9/2015 11:59 AM, Andy Shevchenko wrote:

>>>>> +       if (trigger != ACPI_MADT_TRIGGER_LEVEL ||
>>>>>> +           polarity != ACPI_MADT_POLARITY_ACTIVE_LOW)
>>>>>> +               penalty = PIRQ_PENALTY_ISA_ALWAYS;
>>>>>> +       else
>>>>>> +               penalty = PIRQ_PENALTY_PCI_USING;
>>>>>> +
>>>>>> +       acpi_irq_add_penalty(irq, penalty);

>>>> Why not to change in place? I think a common sense rule is not to
>>>> change something existing if it doesn't add any significant value.

>>>> -               acpi_irq_penalty[irq] += PIRQ_PENALTY_PCI_USING;
>>>> +              acpi_irq_add_penalty(irq, PIRQ_PENALTY_PCI_USING);
>>
>> I think Andy was suggesting that you make the change without introducing
>> the penalty variable.

> Is Chris' interpretation correct?

Yep, I meant not to use an additional variable.

> BTW, I suggest you spend some time around checkpatch for contributions. I could
> have caught most of the issues you are generally concerned before submitting a patch.

Is it a question?

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-30 14:30 +0100
  Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction Sinan Kaya <okaya@codeaurora.org> - 2015-12-30 20:20 +0100
    Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-30 21:00 +0100
      Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-01 01:20 +0100

csiph-web