Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299808

Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction

Show all headers | View raw

On Wednesday, December 30, 2015 09:55:35 PM Andy Shevchenko wrote:
> On Wed, Dec 30, 2015 at 9:17 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
> > On 12/30/2015 8:28 AM, Andy Shevchenko wrote:
> >> Yep, I meant not to use an additional variable.
> >>
> >>> > BTW, I suggest you spend some time around checkpatch for contributions. I could
> >>> > have caught most of the issues you are generally concerned before submitting a patch.
> >> Is it a question?
> >
> > It is a request not a question. I hate wasting your time and my time with things that I could
> > have fixed before submitting a patch.
> >
> > I ran the checkpatch and it said I'm good to go. But, obviously I'm not.
> 
> Hmm… checkpatch.pl is just a small helper to fix style issues. Here is
> just a common sense rule, or kind of Occam's razor: no need to have
> more variables then needed if it doesn't improve something really
> significantly.

That said, compilers optimize things anyway, so using an extra local variable
shouldn't matter for the resulting machine code.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-30 14:30 +0100
  Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction Sinan Kaya <okaya@codeaurora.org> - 2015-12-30 20:20 +0100
    Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-30 21:00 +0100
      Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-01 01:20 +0100
        Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-04 10:10 +0100
          Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-04 14:30 +0100
            Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-04 14:40 +0100

csiph-web