Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq
Date	2015-12-27 12:20 +0100
Message-ID	<qKhwK-6ac-13@gated-at.bofh.it> (permalink)
References	(5 earlier) <qK46u-5K2-7@gated-at.bofh.it> <qK5vA-6ML-29@gated-at.bofh.it> <qK5Ff-6Rn-1@gated-at.bofh.it> <qK5Ff-6Rn-3@gated-at.bofh.it> <qKcQp-3ej-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/27/2015 9:13 AM, Julia Lawall wrote:

>>     Well, looking again, the patch should be good. I just thought its goal was
>> to fix the code as well...
>
> I could do that for the irq < 0 case, but I think that in that case, kbuild
> will only run the patch version, and the <= cases will not be reported on.
> I don't have a general fix for the <= 0.  Is it even correct to have < in
> some cases and <= in others?

    That's a good question...
    In my prior fixes of this case I preferred to consider IRQ0 valid and so 
used 'irq < 0'. I myself don't share the "IRQ0 is invalid" sentiment...

> julia

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] coccinelle: api: check for propagation of error from platform_get_irq Julia Lawall <Julia.Lawall@lip6.fr> - 2015-12-26 20:40 +0100
  Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 21:00 +0100
    Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 21:10 +0100
      Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 21:30 +0100
        Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 21:40 +0100
        [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 22:00 +0100
          Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 23:30 +0100
            Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 23:40 +0100
              Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 23:40 +0100
                Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-27 07:20 +0100
                Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-27 12:20 +0100
          Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of  error from platform_get_irq SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-27 09:00 +0100
            Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of  error from platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-27 12:50 +0100
              Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of  error from platform_get_irq SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-28 03:50 +0100
      Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 21:30 +0100

csiph-web