Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq
Date	2015-12-27 09:00 +0100
Message-ID	<qKepc-42Y-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <qK3aq-598-11@gated-at.bofh.it> <qK3k5-5rM-15@gated-at.bofh.it> <qK3Ds-5yA-5@gated-at.bofh.it> <qK3Ds-5yA-3@gated-at.bofh.it> <qK46u-5K2-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> The error return value of platform_get_irq seems to often get dropped.

How do you think about any more fine-tuning here?

Commit message:
* … of the platform_get_irq() function seems to get dropped too often.

* Why do you concentrate on a single function name?
  Do you plan to extend this source code analysis approach?


> +@script:python r_report depends on report@
> +j0 << r.j0;
> +j1 << r.j1;
> +@@
> +
> +msg = "Propagate return value of platform_get_irq around line %s." % (j1[0].line)

Are there more unchecked return values which are interesting
for further considerations?
https://cwe.mitre.org/data/definitions/252.html

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] coccinelle: api: check for propagation of error from platform_get_irq Julia Lawall <Julia.Lawall@lip6.fr> - 2015-12-26 20:40 +0100
  Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 21:00 +0100
    Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 21:10 +0100
      Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 21:30 +0100
        Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 21:40 +0100
        [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 22:00 +0100
          Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 23:30 +0100
            Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 23:40 +0100
              Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-26 23:40 +0100
                Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-27 07:20 +0100
                Re: [PATCH v2] coccinelle: api: check for propagation of error from  platform_get_irq Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-27 12:20 +0100
          Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of  error from platform_get_irq SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-27 09:00 +0100
            Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of  error from platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-27 12:50 +0100
              Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of  error from platform_get_irq SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-28 03:50 +0100
      Re: [PATCH] coccinelle: api: check for propagation of error from  platform_get_irq Julia Lawall <julia.lawall@lip6.fr> - 2015-12-26 21:30 +0100

csiph-web