Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1298332
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Geliang Tang <geliangtang@163.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 4/5] HID: wiimote: use dev_to_wii() |
| Date | Sun, 27 Dec 2015 10:30:01 +0100 |
| Message-ID | <qKfOh-52f-3@gated-at.bofh.it> (permalink) |
| References | <qKfOh-52f-5@gated-at.bofh.it> |
| X-Original-To | David Herrmann <dh.herrmann@googlemail.com>, Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=mF6GHDi7v7TRSydmM+ lwMEUsaicu5MZZkTAza7Gahlc=; b=Qc0iDDC11rNJ4uecAbe8IEJVZ5yPGo8ekl zDgjdFTT1TduN2y8qga3h0W4XhXLTp7j7jVFGVQk9xRhuRjAr/5w2YaPXnpJC0u9 4cnHXmS8Aq4RJKTdOdoSO9fxAwFjWIO2kwefPyJdUIfmI14Sike7b75spgnavgRs 10yxM205w= |
| X-Mailer | git-send-email 2.5.0 |
| X-Cm-Transid | DNGowEDJmkKOrn9WPLILAA--.4136S3 |
| X-Coremail-Antispam | 1Uf129KBjvJXoW7KFWxJrykXF1kCr4kCFW5Awb_yoW8XryDpF W7W3WYkrWxXr1Du3W8Xw1DuFy3ta4kAas2vry5Cw1SvFy5ZFyUtFyxtFyYqFWrAaykuFsr WF15XryjkFyUKwUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U3UUbUUUUU= |
| X-Originating-IP | [116.77.145.148] |
| X-Cm-Senderinfo | 5jhoxtpqjwt0rj6rljoofrz/1tbioxDdmVUL3ns1ggAAs7 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 52 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Geliang Tang <geliangtang@163.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Sun, 27 Dec 2015 17:25:23 +0800 |
| X-Original-Message-ID | <aa8060c2f9e42359a9b1fc402f8d48ce9045e840.1451206516.git.geliangtang@163.com> |
| X-Original-References | <3490fef13d9af010ff2da07012eed189c46ee3fa.1451206516.git.geliangtang@163.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1298332 |
Show key headers only | View raw
Use dev_to_wii() instead of open-coding it.
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
drivers/hid/hid-wiimote-modules.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-wiimote-modules.c b/drivers/hid/hid-wiimote-modules.c
index 05e23c4..4390eee 100644
--- a/drivers/hid/hid-wiimote-modules.c
+++ b/drivers/hid/hid-wiimote-modules.c
@@ -296,14 +296,12 @@ static const struct wiimod_ops wiimod_battery = {
static enum led_brightness wiimod_led_get(struct led_classdev *led_dev)
{
- struct wiimote_data *wdata;
struct device *dev = led_dev->dev->parent;
+ struct wiimote_data *wdata = dev_to_wii(dev);
int i;
unsigned long flags;
bool value = false;
- wdata = hid_get_drvdata(container_of(dev, struct hid_device, dev));
-
for (i = 0; i < 4; ++i) {
if (wdata->leds[i] == led_dev) {
spin_lock_irqsave(&wdata->state.lock, flags);
@@ -319,14 +317,12 @@ static enum led_brightness wiimod_led_get(struct led_classdev *led_dev)
static void wiimod_led_set(struct led_classdev *led_dev,
enum led_brightness value)
{
- struct wiimote_data *wdata;
struct device *dev = led_dev->dev->parent;
+ struct wiimote_data *wdata = dev_to_wii(dev);
int i;
unsigned long flags;
__u8 state, flag;
- wdata = hid_get_drvdata(container_of(dev, struct hid_device, dev));
-
for (i = 0; i < 4; ++i) {
if (wdata->leds[i] == led_dev) {
flag = WIIPROTO_FLAG_LED(i + 1);
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 4/5] HID: wiimote: use dev_to_wii() Geliang Tang <geliangtang@163.com> - 2015-12-27 10:30 +0100
csiph-web