Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Wim Van Sebroeck <wim@iguana.be>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers
Date	Mon, 28 Dec 2015 23:20:01 +0100
Message-ID	<qKOiZ-8ic-3@gated-at.bofh.it> (permalink)
References	<qJmyt-3WH-1@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.4.1i
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	linux-watchdog@vger.kernel.org, Damien Riegel <damien.riegel@savoirfairelinux.com>, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 28 Dec 2015 23:15:10 +0100
X-Original-Message-ID	<20151228221510.GB1889@spo001.leaseweb.nl>
X-Original-References	<1450995724-17758-1-git-send-email-linux@roeck-us.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1298772

Show key headers only | View raw

Hi Guenter,

> The 'dev' variable in watchdog drivers has a different lifetime than the
> watchdog character device and should therefore not be used by watchdog
> drivers.
> 
> Some of the drivers use the variable to print kernel messages. Those
> messages are either dropped or changed to use the parent device.
> One driver sets the variable during initialization to the watchdog
> driver's parent device, which is wrong and was removed.
> 
> v2: Use parent device for dev_XXX messages instead of pr_XXX.

This patchset has been added to linux-watchdog-next.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 5/5] watchdog: qcom-wdt: Do not set 'dev' in struct watchdog_device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 3/5] watchdog: gpio: Do not use device pointer from struct watchdog_device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 4/5] watchdog: mena21: Do not use device pointer from struct watchdog_device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 1/5] watchdog: bcm2835_wdt: Drop log message if watchdog is stopped Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 2/5] watchdog: tangox: Print info message using pointer to platform device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Wim Van Sebroeck <wim@iguana.be> - 2015-12-28 23:20 +0100
    Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device  in watchdog drivers Guenter Roeck <linux@roeck-us.net> - 2015-12-29 01:10 +0100

csiph-web