Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers
Date	2015-12-29 01:10 +0100
Message-ID	<qKQ1t-10i-39@gated-at.bofh.it> (permalink)
References	<qJmyt-3WH-1@gated-at.bofh.it> <qKOiZ-8ic-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 28, 2015 at 11:15:10PM +0100, Wim Van Sebroeck wrote:
> Hi Guenter,
> 
> > The 'dev' variable in watchdog drivers has a different lifetime than the
> > watchdog character device and should therefore not be used by watchdog
> > drivers.
> > 
> > Some of the drivers use the variable to print kernel messages. Those
> > messages are either dropped or changed to use the parent device.
> > One driver sets the variable during initialization to the watchdog
> > driver's parent device, which is wrong and was removed.
> > 
> > v2: Use parent device for dev_XXX messages instead of pr_XXX.
> 
> This patchset has been added to linux-watchdog-next.
> 

Thanks!

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 5/5] watchdog: qcom-wdt: Do not set 'dev' in struct watchdog_device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 3/5] watchdog: gpio: Do not use device pointer from struct watchdog_device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 4/5] watchdog: mena21: Do not use device pointer from struct watchdog_device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 1/5] watchdog: bcm2835_wdt: Drop log message if watchdog is stopped Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  [PATCH v2 2/5] watchdog: tangox: Print info message using pointer to platform device Guenter Roeck <linux@roeck-us.net> - 2015-12-24 23:30 +0100
  Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Wim Van Sebroeck <wim@iguana.be> - 2015-12-28 23:20 +0100
    Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device  in watchdog drivers Guenter Roeck <linux@roeck-us.net> - 2015-12-29 01:10 +0100

csiph-web