Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1298612

Re: [PATCH v5 09/20] ARC: IRQ: use device tree to get timer device configuration

Show all headers | View raw

On Sunday 27 December 2015 06:53 PM, Noam Camus wrote:
> From: Noam Camus <noamc@ezchip.com>
> 
> We've designated:
> TIMER0 for events (clockevents)
> TIMER1 for free running (clocksource)
> 
> Till now timer configuration was done on arch/arc/kernel/time.c
> with constant values.
> 
> This commit add device tree support so we can do this work
> at dedicated clocksource driver which parse the DT blob.
> 
> Such driver will get clocksource rate as well as interrupt line
> from DT and use them for setting clocksourcse and clockevents.
> 
> Note that lately called of_clk_init() is moved before we call
> clocksource_probe() since at that time device from DT
> need a "provider" (clocks) which will be available only after
> we call to of_clk_init().
> 
> Signed-off-by: Noam Camus <noamc@ezchip.com>
> Acked-by: Vineet Gupta <vgupta@synopsys.com>

For patches which change semantically, ACK should not be copied over from prev
version. I do have some reservation with this patch.

I think we should just fix ARC once and for all by removing the legacy
registration. This would be a flag day change but I think we should be fine !
No point in keeping 2 implementations !

@Noam let me take a stab at it - OK !

-Vineet



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 00/20] Adding plat-eznps to ARC Noam Camus <noamc@ezchip.com> - 2015-12-27 14:50 +0100
  Re: [PATCH v5 09/20] ARC: IRQ: use device tree to get timer device  configuration Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-28 12:50 +0100
  Re: [PATCH v5 05/20] irqchip: add nps Internal and external irqchips Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-30 11:10 +0100
  Re: [PATCH v5 10/20] ARC: IRQ: do not use hwirq directly at  arch_do_IRQ() Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-30 11:20 +0100
    Re: [PATCH v5 10/20] ARC: IRQ: do not use hwirq directly at  arch_do_IRQ() Noam Camus <noamc@ezchip.com> - 2015-12-31 06:30 +0100
  Re: [PATCH v5 11/20] ARC: IPI: do not use generic IRQ domain Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-30 11:20 +0100
    Re: [PATCH v5 11/20] ARC: IPI: do not use generic IRQ domain Noam Camus <noamc@ezchip.com> - 2015-12-31 06:20 +0100
  Re: [PATCH v5 05/20] irqchip: add nps Internal and external irqchips Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-30 11:50 +0100
  Re: [PATCH v5 09/20] ARC: IRQ: use device tree to get timer device  configuration Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-30 12:30 +0100
  Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-01 11:40 +0100

csiph-web