Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put
Date	2015-12-22 14:30 +0100
Message-ID	<qIvaN-4uK-1@gated-at.bofh.it> (permalink)
References	<qIbYu-zb-7@gated-at.bofh.it> <qIbYu-zb-5@gated-at.bofh.it> <qIuy6-41F-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Linus,

On Tue, Dec 22, 2015 at 1:47 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Dec 21, 2015 at 5:39 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>> for_each_child_of_node performs an of_node_get on each iteration, so a
>> goto out of the loop requires an of_node_put.
>>
>> A simplified version of the semantic patch that fixes this problem is as
>> follows (http://coccinelle.lip6.fr):
>
> Patch applied with Laurent's ACK.
>
> Geert: since I don't think you're gonna send me more pull
> requests before the merge window I went ahead and applied
> this directly, OK?

You're reading my mind ;-)

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-12-21 18:00 +0100
  Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-12-21 21:50 +0100
  Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put Linus Walleij <linus.walleij@linaro.org> - 2015-12-22 13:50 +0100
    Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put Geert Uytterhoeven <geert@linux-m68k.org> - 2015-12-22 14:30 +0100

csiph-web